feat: add option to show temperature at the top-left corner of the graph #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding config item "Plasmoid.configuration.thirdLineToLeftTopCorner" in ConfigAppearance.qml, and adding positioning anchors control in GraphText.qml. And after enabling this feature, the temperature with one decimal digit, such as "45.6°C", is not beautiful,so in CpuTemperature.qml:getFormattedValue(), precision control is implemented to keep the temperature always integer.
|
Hello, sorry for the long pause on that project, i havent take time check the issues. I'm not a big fan of that render but i see the point of it, i will check to implement that after implementing #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implements showing temperature at the top-left corner of the graph.
Implemetation Keypoints:
ConfigAppearance.qml: Adds a config item "Plasmoid.configuration.thirdLineToLeftTopCorner"GraphText.qml: Adding positioning anchors control codes in GraphText.qml. Please review the code.CpuTemperature.qml: The temperature used to be shown with one decimal digit, such as "45.6°C". After moving the temperature to the top-left corner, This is not very beautiful as there will be nearly no space between the temperature and the percentage. so inCpuTemperature.qml:getFormattedValue(), precision control is implemented to keep the temperature always integer, such as "45°C".