Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml lexer performance improvement used in vis #15

Closed
wants to merge 1 commit into from

Conversation

moesasji
Copy link

This adds performance improvements for the xml lexer added to vis in commits: 7e9e0a2ca868aaa214fb38a79fe71da34d6e00da and
baa51e934ce057af5b5be829d6a73a3e8b4c03d0

This adds performance improvements added to vis in commits:
7e9e0a2ca868aaa214fb38a79fe71da34d6e00da and
baa51e934ce057af5b5be829d6a73a3e8b4c03d0
@orbitalquark
Copy link
Owner

orbitalquark commented Dec 24, 2020 via email

@mcepl
Copy link

mcepl commented Sep 30, 2024

This change does not correctly handle the following input:

<size
width=100
height=100>

Just that this is not correct XML, attributes must be quoted. For my test text (18 MB text of Bible) it seems to work just fine:

xml-element

@mcepl
Copy link

mcepl commented Sep 30, 2024

All three related PRs are rebased on the current master in the devel branch, i.e. in https://git.sr.ht/~mcepl/vis/commit/92e7198cfc81

@mcepl mcepl mentioned this pull request Oct 3, 2024
@orbitalquark
Copy link
Owner

Closing per comments in #118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants