ansible-lint V6.20.3

.ansible-lint

@@ -7,6 +7,7 @@ skip_list:
   # ansible-oracle has lot of internal used variables...
   - var-naming[no-role-prefix]
   - name[casing]
+  - meta-runtime[unsupported-version]
 
 exclude_paths:
   - .github

.github/workflows/ansible-lint.yml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v2
 
       - name: Lint roles
-        uses: ansible-community/ansible-lint-action@v6.17.0
+        uses: ansible/ansible-lint@v6.20.3
         with:
           targets: |
             inventory/*

.pre-commit-config.yaml

@@ -48,7 +48,7 @@ repos:
         entry: ansible-doctor -r -f roles
 
   - repo: https://github.com/ansible-community/ansible-lint.git
-    rev: v6.17.0
+    rev: v6.20.3
     hooks:
       - id: ansible-lint
         entry: ansible-lint --force-color -p

changelogs/fragments/ansible-lint.yml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - "ansible-lint V6.20.3 ()"

roles/oradb_datapatch/tasks/main.yml

@@ -3,6 +3,7 @@
   ansible.builtin.shell: "export PATH=${ORACLE_HOME}/bin:${PATH}; lsnrctl start {{ lsnrinst.listener_name }} /dev/null; exit 0"
   # noqa no-changed-when
   environment: "{{ oracle_env_lsnrctl }}"
+  become: true
   become_user: "{{ oracle_user }}"
   with_items: "{{ listener_installed }}"
   loop_control:
@@ -22,6 +23,7 @@
     db_unique_name: "{{ odb.oracle_db_unique_name | default(omit) }}"
     sid: "{{ odb.oracle_db_instance_name | default(omit) }}"
     state: started
+  become: true
   become_user: "{{ oracle_user }}"
   with_items: "{{ oracle_databases | selectattr('state', 'match', 'present') }}"
   loop_control:

roles/oradb_manage_db/tasks/manage-db.yml

@@ -149,6 +149,7 @@
     output: verbose
     state: "{{ odb.state }}"
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   when: odb.state == 'absent'
   register: dbca_remove

roles/oradb_manage_grants/tasks/main.yml

@@ -25,6 +25,7 @@
     - odb.0.state == 'present'
     - (odb.1.grants is defined or odb.1.object_privs is defined)
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
@@ -63,6 +64,7 @@
     - opdb.0.state == 'present'
     - (opdb.1.grants is defined or opdb.1.object_privs is defined)
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: opdb
@@ -103,6 +105,7 @@
     - odb.0.state == 'present'
     - (odb.1.grants is defined or odb.1.object_privs is defined)
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
@@ -141,6 +144,7 @@
     - opdb.0.state == 'present'
     - (opdb.1.grants is defined or opdb.1.object_privs is defined)
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: opdb

roles/oradb_manage_parameters/tasks/main.yml

@@ -24,6 +24,7 @@
     - oracle_databases is defined
     - odb.0.state == 'present'
     - odb.1 is defined
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
@@ -63,6 +64,7 @@
     - oracle_pdbs is defined
     - opdb.0.state == 'present'
     - opdb.1 is defined
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: opdb
@@ -100,6 +102,7 @@
     label: >-
       dbname: {{ odb.0.oracle_db_name | d('') }}
       - {{ param_change_reboot.msg | default('restart_spparameter_changed is false') }}"
+  become: true
   become_user: "{{ oracle_user }}"
   register: param_change_reboot
   tags: spfile_bounce

roles/oradb_manage_roles/tasks/main.yml

@@ -28,6 +28,7 @@
       role {{ odb.1.name }}
       state {{ odb.1.state }}
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   tags: users,grants
 
@@ -60,5 +61,6 @@
       role: {{ opdb.1.name }},
       state: {{ opdb.1.state }}
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   tags: users,grants

roles/oradb_manage_services/tasks/main.yml

@@ -32,6 +32,7 @@
     - odb.0.state == 'present'
     - odb.1 is defined
     - (odb.1.state == 'present' or odb.1.state == 'started')
+  become: true
   become_user: "{{ oracle_user }}"
   tags: create_service,services
 
@@ -61,6 +62,7 @@
     - item.0.state == 'present'
     - item.1 is defined
     - (item.1.state == 'present' or item.1.state == 'started')
+  become: true
   become_user: "{{ oracle_user }}"
   tags: create_service,services
 
@@ -87,6 +89,7 @@
     - item.0.state | lower == 'present'
     - item.1 is defined
     - item.1.state == 'started'
+  become: true
   become_user: "{{ oracle_user }}"
   tags: start_service,services
 
@@ -112,6 +115,7 @@
     - oracle_pdbs is defined
     - item.0.state == 'present'
     - item.1 is defined and item.1.state == 'started'
+  become: true
   become_user: "{{ oracle_user }}"
   tags: start_service,services
 
@@ -138,6 +142,7 @@
     - item.0.state | lower == 'present'
     - item.1 is defined
     - item.1.state == 'stopped' or item.1.state == 'absent'
+  become: true
   become_user: "{{ oracle_user }}"
   tags: start_service,services
 
@@ -164,6 +169,7 @@
     - item.0.state | lower == 'present'
     - item.1 is defined
     - item.1.state == 'stopped' or item.1.state == 'absent'
+  become: true
   become_user: "{{ oracle_user }}"
   tags: start_service,services
 
@@ -190,6 +196,7 @@
     - item.0.state | lower == 'present'
     - item.1 is defined
     - item.1.state == 'absent'
+  become: true
   become_user: "{{ oracle_user }}"
   tags: start_service,services
 
@@ -216,5 +223,6 @@
     - item.0.state == 'present'
     - item.1 is defined
     - item.1.state == 'absent'
+  become: true
   become_user: "{{ oracle_user }}"
   tags: start_service,services

roles/oradb_manage_statspack/tasks/main.yml

@@ -138,6 +138,7 @@
     - odb.0.state == 'present'
     - odb.0.statspack is defined
     - odb.0.statspack.state == 'present'
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
@@ -169,6 +170,7 @@
     - odb.0.state == 'present'
     - odb.0.statspack is defined
     - odb.0.statspack.state == 'present'
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
@@ -302,6 +304,7 @@
     - opdb.0.state == 'present'
     - opdb.0.statspack is defined
     - opdb.0.statspack.state == 'present'
+  become: true
   become_user: "{{ oracle_user }}"
   tags:
     - spjob

roles/oradb_manage_users/tasks/main.yml

@@ -30,6 +30,7 @@
     - odb.0.state == 'present'
     - odb.1 is defined
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     loop_var: odb
@@ -73,6 +74,7 @@
     - opdb.1.schema is defined
     - opdb.1.state is defined
   run_once: "{{ _oraswgi_meta_configure_cluster }}"
+  become: true
   become_user: "{{ oracle_user }}"
   loop_control:
     label: >-

roles/oradb_rman/tasks/main.yml

@@ -284,6 +284,7 @@
     - wallet
 
 - name: Register Database in RMAN Catalog
+  become: true
   become_user: "{{ oracle_user }}"
   ansible.builtin.shell:
     cmd: "$ORACLE_HOME/bin/rman target / catalog $CONNECTSTRING"

roles/oradb_tzupgrade/tasks/cdb.yml

@@ -8,6 +8,7 @@
     scope: pdbs
     pdb_list: "CDB$ROOT PDB$SEED"
   become_user: "{{ oracle_user }}"
+  become: true
 
 - name: oradb_tzupgrade | Upgrade timezone for CDB$ROOT and PDB$SEED
   opitzconsulting.ansible_oracle.oracle_sqldba:
@@ -18,6 +19,7 @@
     scope: pdbs
     pdb_list: "CDB$ROOT PDB$SEED"
   become_user: "{{ oracle_user }}"
+  become: true
 
 - name: oradb_tzupgrade | Get all open PDBs
   opitzconsulting.ansible_oracle.oracle_sqldba:
@@ -28,6 +30,7 @@
     oracle_home: "{{ _oracle_home_db }}"
     oracle_db_name: "{{ _oracle_db_instance_name }}"
   become_user: "{{ oracle_user }}"
+  become: true
   register: pdbs_info
 
 - name: oradb_tzupgrade | Set facts for pdbs_info
@@ -51,6 +54,7 @@
         pdb_list: "{{ _oradb_tzupgrade_candidate_pdbs }}"
         oracle_db_name: "{{ _oracle_db_instance_name }}"
       become_user: "{{ oracle_user }}"
+      become: true
 
     - name: oradb_tzupgrade | Upgrade timezone for the candidate PDBs
       opitzconsulting.ansible_oracle.oracle_sqldba:
@@ -61,6 +65,7 @@
         pdb_list: "{{ _oradb_tzupgrade_candidate_pdbs }}"
         oracle_db_name: "{{ _oracle_db_instance_name }}"
       become_user: "{{ oracle_user }}"
+      become: true
 
 - name: oradb_tzupgrade | Get post upgrade timezone status info
   opitzconsulting.ansible_oracle.oracle_sqldba:
@@ -82,6 +87,7 @@
     oracle_home: "{{ _oracle_home_db }}"
     oracle_db_name: "{{ _oracle_db_instance_name }}"
   become_user: "{{ oracle_user }}"
+  become: true
   changed_when: false
   register: post_status_info
 

roles/oradb_tzupgrade/tasks/non_cdb.yml

@@ -5,6 +5,7 @@
     creates_sql: "{{ _oradb_tzupgrade_tz_check_query }}"
     oracle_home: "{{ _oracle_home_db }}"
     oracle_db_name: "{{ _oracle_db_instance_name }}"
+  become: true
   become_user: "{{ oracle_user }}"
 
 - name: oradb_tzupgrade | Apply the timezone upgrade for the non-CDB database
@@ -13,6 +14,7 @@
     creates_sql: "{{ _oradb_tzupgrade_tz_check_query }}"
     oracle_home: "{{ _oracle_home_db }}"
     oracle_db_name: "{{ _oracle_db_instance_name }}"
+  become: true
   become_user: "{{ oracle_user }}"
 
 - name: oradb_tzupgrade | Get post upgrade timezone status info
@@ -28,6 +30,7 @@
         FROM database_properties WHERE property_name LIKE 'DST_PRIMARY_TT_VERSION';
     oracle_home: "{{ _oracle_home_db }}"
     oracle_db_name: "{{ _oracle_db_instance_name }}"
+  become: true
   become_user: "{{ oracle_user }}"
   changed_when: false
   register: post_status_info

tools/dev/requirements_dev.txt

@@ -12,7 +12,7 @@
 # . ~/venv/ansible-oracle/bin/activate
 # pip --require-virtualenv -v install -r tools/dev/requirements_dev.txt
 #
-ansible-lint==6.17.0
+ansible-lint==6.20.3
 ansible-navigator==3.4.0
 pre-commit==3.4.0