Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: minimal dep on containerd #312

Merged
merged 15 commits into from
Sep 20, 2021
Merged

Feat: minimal dep on containerd #312

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
534cf09
Remove mediatype from artifact manifest
sajayantony Sep 13, 2021
c7911c3
Add support for pre-release
sajayantony Sep 13, 2021
d011808
Updated oras-project/containerd with artifact filtering (#313)
sajayantony Sep 14, 2021
3e8fd97
Feat: minimal dep on containerd
juliusl Sep 14, 2021
4d4bde9
PR: Fixed the field name
juliusl Sep 14, 2021
f45a26a
Bug: Fixed opts handling
juliusl Sep 19, 2021
8119e4d
Fixup: cleaning up unintended files
juliusl Sep 19, 2021
04dd384
Cleanup: Adding back dummy discover function
juliusl Sep 19, 2021
f7cdc9a
PR: Addressing PR feedback
juliusl Sep 19, 2021
765c610
Clean: go mod tidy
juliusl Sep 19, 2021
15a26e0
Feat: Adds pushing artifact manifests
juliusl Sep 20, 2021
179634e
PR: removing branching logic in push.go
juliusl Sep 20, 2021
811dea6
Test: Adding test for discover override
juliusl Sep 20, 2021
654e45e
Fixup: Restored LICENSE lost in rebase
juliusl Sep 20, 2021
80638a0
Merge branch 'artifacts' into juliusl/artifacts
sajayantony Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR: removing branching logic in push.go 
(confirmed tested that --dry-run still works)

Signed-off-by: Julius Liu <juliusl@microsoft.com>
  • Loading branch information
@juliusl
juliusl committed Sep 20, 2021
commit 179634ecec01bcdb0019c414fe9735e8ff165d87
13 changes: 4 additions & 9 deletions cmd/oras/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,12 @@ func runPush(opts pushOptions) error {
// bake artifact
var pushOpts []oras.PushOpt
if opts.artifactType != "" {
refResolver := resolver
if iresolver.IsDummy(resolver) {
refResolver, _ = newResolver(opts.username, opts.password, opts.insecure, opts.plainHTTP, opts.configs...)
} else {
resolver, err = orasDocker.WithDiscover(opts.artifactRefs, resolver, orasDocker.NewOpts(ropts))
if err != nil {
return err
}
resolver, err = orasDocker.WithDiscover(opts.artifactRefs, resolver, orasDocker.NewOpts(ropts))
if err != nil {
return err
}

manifest, err := loadReference(ctx, refResolver, opts.artifactRefs)
manifest, err := loadReference(ctx, resolver, opts.artifactRefs)
if err != nil {
return err
}
Expand Down