Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace obsolete html element #1372

Merged
merged 2 commits into from
May 6, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

The align element was made obsolete in html 5

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (33a28e7) to head (4175598).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         104      104           
  Lines        3706     3706           
=======================================
  Hits         3142     3142           
  Misses        336      336           
  Partials      228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit 3812a2d into oras-project:main May 6, 2024
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe deleted the obsolete-readme-element branch May 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants