Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge package credentials back from oras-credentials-go #589

Merged
merged 8 commits into from
Sep 8, 2023

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Sep 6, 2023

  1. Add package credentials (migrated from oras-credentials-go) and its corresponding description
  2. Add new type auth.CredentialFunc
  3. Migrate the credentials example from oras.land
  4. Change auth.DefaultCache to auth.NewCache() in examples

Resolves: #584

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #589 (75100f8) into main (92eb05c) will increase coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 76.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   74.21%   74.36%   +0.14%     
==========================================
  Files          51       58       +7     
  Lines        4832     5246     +414     
==========================================
+ Hits         3586     3901     +315     
- Misses        914      991      +77     
- Partials      332      354      +22     
Files Changed Coverage Δ
registry/remote/credentials/trace/trace.go 0.00% <0.00%> (ø)
registry/remote/credentials/native_store_linux.go 80.00% <80.00%> (ø)
...istry/remote/credentials/internal/config/config.go 80.36% <80.36%> (ø)
registry/remote/credentials/store.go 80.95% <80.95%> (ø)
registry/remote/credentials/registry.go 81.25% <81.25%> (ø)
registry/remote/credentials/native_store.go 83.33% <83.33%> (ø)
registry/remote/auth/client.go 73.12% <100.00%> (ø)
registry/remote/credentials/file_store.go 100.00% <100.00%> (ø)

📢 Have feedback on the report? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit c130949 into oras-project:main Sep 8, 2023
@Wwwsylvia Wwwsylvia deleted the credentials branch September 8, 2023 07:23
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge oras-credentials-go back
4 participants