Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci.Store and oci.Storage should implement content.Deleter #454

Closed
qweeah opened this issue Mar 4, 2023 · 2 comments
Closed

oci.Store and oci.Storage should implement content.Deleter #454

qweeah opened this issue Mar 4, 2023 · 2 comments
Assignees
@wangxiaoxuan273
Labels
enhancement New feature or request
Milestone
v2.4.0

Comments

@qweeah
Copy link
Contributor

qweeah commented Mar 4, 2023

oci.Store and oci.Store should implement content.Deleter to provide base delete operations on index.json without garbage collection.
@qweeah qweeah mentioned this issue Mar 4, 2023
Closed
@qweeah qweeah changed the title oci.Store and oci.Store should implement content.Deleter oci.Store and oci.Storage should implement content.Deleter Mar 4, 2023
@qweeah qweeah mentioned this issue Mar 4, 2023
Closed
carabasdaniel added a commit to opcr-io/policy that referenced this issue Mar 13, 2023
@carabasdaniel
Hack to allow rm to work with oras v2 until oras-project/oras-go#454
83a73f9 
Signed-off-by: carabasdaniel <dani@aserto.com>
carabasdaniel added a commit to opcr-io/policy that referenced this issue Mar 13, 2023
@carabasdaniel
Hack to allow rm to work with oras v2 until oras-project/oras-go#454
3b8fecd 
Signed-off-by: carabasdaniel <dani@aserto.com>
carabasdaniel added a commit to opcr-io/policy that referenced this issue Mar 15, 2023
@carabasdaniel
Bump oras to v2 (#126)
eeeedda 
* Bump oras-go to v2

* Update build to oras v2

Signed-off-by: carabasdaniel <dani@aserto.com>

* Fix push & tag

* Allow rebuild

Signed-off-by: carabasdaniel <dani@aserto.com>

* Fix build images

* Oci Tag only on not resolved

Signed-off-by: carabasdaniel <dani@aserto.com>

* PostCopy tag

Signed-off-by: carabasdaniel <dani@aserto.com>

* Add copyskipped

Signed-off-by: carabasdaniel <dani@aserto.com>

* Add media type check for copy options

Signed-off-by: carabasdaniel <dani@aserto.com>

* Extract remote manager

Signed-off-by: carabasdaniel <dani@aserto.com>

* Test with pre-release

Signed-off-by: carabasdaniel <dani@aserto.com>

* Fix on rebase

Signed-off-by: carabasdaniel <dani@aserto.com>

* Use oci package in repl

Signed-off-by: carabasdaniel <dani@aserto.com>

* Hack to allow rm to work with oras v2 until oras-project/oras-go#454

Signed-off-by: carabasdaniel <dani@aserto.com>

* Use oras v2 in save command

Signed-off-by: carabasdaniel <dani@aserto.com>

* Use oras v2 in inspect

Signed-off-by: carabasdaniel <dani@aserto.com>

* Fix linting errors

Signed-off-by: carabasdaniel <dani@aserto.com>

---------

Signed-off-by: carabasdaniel <dani@aserto.com>
Co-authored-by: oanatmaria <oana@aserto.com>
@shizhMSFT shizhMSFT added this to the v2.2.0 milestone Mar 22, 2023
@shizhMSFT shizhMSFT added the enhancement New feature or request label Mar 22, 2023
@carabasdaniel carabasdaniel mentioned this issue Mar 23, 2023
Closed
@shizhMSFT shizhMSFT mentioned this issue Mar 27, 2023
Open
@wangxiaoxuan273
Copy link
Contributor

I'd like to work on this.

@yizha1 yizha1 modified the milestones: v2.3.0, v2.4.0 Aug 1, 2023
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Sep 1, 2023
Closed
This was referenced Sep 25, 2023
Merged
Merged
Merged
TerryHowe pushed a commit that referenced this issue Oct 2, 2023
@wangxiaoxuan273
feat: support deletion for memory resolver (#607)
6456d16 
Part 2/4 of #454 

Based on draft PR #582

---------

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Co-authored-by: Terry Howe <tlhowe@amazon.com>
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Oct 7, 2023
Merged
TerryHowe pushed a commit that referenced this issue Oct 7, 2023
@wangxiaoxuan273
feat: support deletion for OCI storage (#608)
7eef77e 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Part 3/4 of #454

Based on draft PR #582

---------

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Wwwsylvia pushed a commit that referenced this issue Oct 16, 2023
@wangxiaoxuan273
feat: support deletion for memory graph (#606)
459a246 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Part 1/4 of #454

Based on draft PR #582 

Current behavior regarding `graph.Memory.Remove(node)`:
* `node` entry in `m.successors` and `m.nodes` is removed.
* `node` is removed from its successors predecessors list.
* `node` entry in `m.predecessors` is NOT removed, **unless all its
predecessors no longer exist**.
* `node` is NOT removed from its predecessors' `m.successors` list. The
`m.successors` is always in accordance with the actual content.

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT pushed a commit that referenced this issue Nov 20, 2023
@wangxiaoxuan273
feat: extend oci.Store with Delete() (#614)
75d200e 
Part 4/4 of #454 

This PR should be reviewed and merged after PR #606 #607 #608

---------

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@Wwwsylvia
Copy link
Member

Resolving as closed by #606, #607, #608, and #614.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangxiaoxuan273 wangxiaoxuan273

Labels
enhancement New feature or request
Projects
ORAS Project Board-2023
Status: Done
Milestone
v2.4.0
5 participants
@qweeah @Wwwsylvia @shizhMSFT @wangxiaoxuan273 @yizha1