Fix missing response code mapping for 410 code #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
410 is in the specs https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#unbinding and should not converted to 500 Fixes #435 Hot fix before mapping all code to original now that we bump to spring5 which provides this support
Even though ``` 2021-08-26 12:11:50.361 DEBUG 7236 --- [-auto-1-exec-10] .m.m.a.ExceptionHandlerExceptionResolver : Using @ExceptionHandler org.springframework.cloud.servicebroker.controller.ServiceBrokerWebMvcExceptionHandler#handleException(Exception) 2021-08-26 12:11:50.364 ERROR 7236 --- [-auto-1-exec-10] .s.c.ServiceBrokerWebMvcExceptionHandler : Unknown exception handled: org.springframework.web.server.ResponseStatusException: 400 BAD_REQUEST "inner-broker-provided-error-description" 2021-08-26 12:11:50.376 INFO 7236 --- [ main] okhttp3.OkHttpClient : <-- 500 http://127.0.0.1:43017/v2/service_instances/111/service_bindings/333?accepts_incomplete=false (1607ms) ```
…higher precedence
…field in parsed OSB response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
410 is in the specs https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#unbinding and should not converted to 500
Fixes #435
And now maps all inner broker error codes to their original code + message.