Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine git processor traces and fix locking of COA consistency check pipeline upon rejected git push on OSB delete #397

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

gberche-orange
Copy link
Member

@gberche-orange gberche-orange commented Jun 17, 2021

Refine traces for help diagnostic #398

  • RunException refined to include failed status
  • info logs with push errors replaced with error logs so that common broker scripts displays them in smoke tests assertions.
  • error logs now use pretty print for push and rebase results

Fixes #399

- RunException refined to include failed status
- info logs with push errors replaced with error logs so that common broker scripts displays them in smoke tests assertions.
- error logs now use pretty print for push and rebase results
This would be hard to reliably unit test using jgit:
- would likely require multiple threads making concurrent conflicting commits and check that they all try to rebase and succeed.

Fixes #398
…t git commit push first in paas-secret and then paas-templates
@gberche-orange gberche-orange changed the title Refined exception and logging during push errors Refine git processor traces and fix locking of COA consistency check pipeline upon rejected git push on OSB delete Jun 21, 2021
…on OSB delete

Now registers deleteProcessors into which secrets repo post-delete step happen before templates repo

Fix #399
@gberche-orange gberche-orange merged commit 3734752 into develop Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSB unprovision should clean first paas-secret before paas-templates
1 participant