perf: remove unused properties from radix #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@H4ad tests are not passing, but I can't understand how this refactor could affect pagination results |
|
@micheleriva Probably is due the default sort is not stable: https://medium.com/@fsufitch/is-javascript-array-sort-stable-46b90822543f |
|
@allevo any thoughts here? |
|
I'm not worried about it. The sorting feature has a dedicated test suite, so it is preserved. @H4ad could you fix the test suite? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no reason for
radixto have anidorparentproperty, so can we remove it?This breaks a test in
dataset.test.ts, but breaks the order of thesnapshot, from what I can see the documents are just being returned in a different order than expected.