Skip to content

Adjust slider panel sizes when container is resized #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Adjust slider panel sizes when container is resized #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 19 additions & 26 deletions webui/src/js/utils/screen-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* @license
* Copyright (c) 2021, Oracle and/or its affiliates.
* Copyright (c) 2021, 2023, Oracle and/or its affiliates.
* Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
*/
'use strict';
Expand Down Expand Up @@ -32,18 +32,7 @@ define(['knockout', 'ojs/ojcorerouter'],
parentSize: vertical ? parentElement.offsetHeight : parentElement.offsetWidth
};

const percent = this.sliderPositions[name];
if (percent) {
if (vertical) {
const oneHeight = Math.round(percent * parentElement.offsetHeight);
onePane.style.height = oneHeight + 'px';
twoPane.style.height = (parentElement.offsetHeight - oneHeight) + 'px';
} else {
const oneWidth = Math.round(percent * parentElement.offsetWidth);
onePane.style.width = oneWidth + 'px';
twoPane.style.width = (parentElement.offsetWidth - oneWidth) + 'px';
}
}
resizeFromSliderPosition();

slider.onmousedown = (e => {
lastDown = {
Expand Down Expand Up @@ -84,23 +73,27 @@ define(['knockout', 'ojs/ojcorerouter'],
window.api.ipc.send('set-divider-location', name, mouseUpPercent);
}

new ResizeObserver(() => {
// if the parent container was resized in the specified direction,
// clear any assigned heights or widths

if(lastDown) {
function resizeFromSliderPosition() {
const percent = thisUtil.sliderPositions[name];
if (percent) {
if (vertical) {
if(lastDown.parentSize !== parentElement.offsetHeight) {
onePane.style.height = null;
twoPane.style.height = null;
}
const oneHeight = Math.round(percent * parentElement.offsetHeight);
onePane.style.height = oneHeight + 'px';
twoPane.style.height = (parentElement.offsetHeight - oneHeight) + 'px';
} else {
if(lastDown.parentSize !== parentElement.offsetWidth) {
onePane.style.width = null;
twoPane.style.width = null;
}
const oneWidth = Math.round(percent * parentElement.offsetWidth);
onePane.style.width = oneWidth + 'px';
twoPane.style.width = (parentElement.offsetWidth - oneWidth) + 'px';
}
}
}

new ResizeObserver(() => {
// if the parent container was resized, resize panels based on slider position.

if(lastDown) {
resizeFromSliderPosition();
}
}).observe(parentElement);
};

Expand Down