-
Notifications
You must be signed in to change notification settings - Fork 217
Support custom PVC, default domain home and default log home #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID. Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID. Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…oracle/weblogic-kubernetes-operator into improve_samples_OOTB_experience Signed-off-by: doxiao <dongbo.xiao@oracle.com> Conflicts: kubernetes/samples/scripts/create-weblogic-domain-pv-pvc/create-pv-pvc.sh kubernetes/samples/scripts/create-weblogic-domain-pv-pvc/pv-template.yaml kubernetes/samples/scripts/create-weblogic-domain-pv-pvc/pvc-template.yaml
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Please see the note, this change has to wait until the intermittent issue is resolved. |
The overall change LGTM. I'm OK with it is now, but wonder if there should be additional discussion about:
|
See the newly added notes in the description.
Just to be clear. The change in this PR defaults the domain home to /shared/domains/domainUID (no /domainName). I believe you are proposing adding /domainName to the path. I believe that this has been brought up and discarded in the slack channel when the proposal (in the description) was discussed. |
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID. Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
There are problems after sync up with the latest develop branch. Looking. |
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID. Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…oracle/weblogic-kubernetes-operator into improve_samples_OOTB_experience Conflicts: integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
The new issue in integration test has been resolved. |
…ation test with WDT Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Passed the full Java integration test locally and on Jenkins http://****/job/weblogic-kubernetes-operator-javatest/224/. |
Note: currently there is an intermittent issue in the integration test with the changes.
Item #1 and #2 are based on the following summary in the slack channel on 10/12/2018.
Tom Moreau [11:35 AM]
Here's a summary of our domain pv decisions (I ran this by Ryan this morning):
@anpanigr @vanajamukkara @maggiehe00