Skip to content

Support custom PVC, default domain home and default log home #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Oct 27, 2018

Conversation

doxiao
Copy link
Member

@doxiao doxiao commented Oct 23, 2018

  1. Default domainHome to /shared/domains/domainUID
  2. Default logHome to /shared/logs/domainUID
  3. Support custom pvc
  4. Support shared pv/vpc - added a new input property for pv/pvc base name
  5. Decouple the output location of the pv/pvc, domain, and load balancer scripts
  6. Modify the integration test code to work with the new samples - did not change the test logic, which means we still have one pv per domain.

Note: currently there is an intermittent issue in the integration test with the changes.

Item #1 and #2 are based on the following summary in the slack channel on 10/12/2018.

Tom Moreau [11:35 AM]

Here's a summary of our domain pv decisions (I ran this by Ryan this morning):

  1. the architectural statement (which does not imply large amounts of work for 2.0): previously, we were focused on one pv per domain. now we're going to shift the focus - instead of encouraging one pv per domain, we're going to say that the customer creates a pv and can put one or more domains on it (just like the customer can create a namespace and put a bunch of domains in it) that is, we're going to say that it's a common use case for domains to share a pv, and we should change the operator runtime and samples to reflect this.
  2. this has implications in the default values on the domain resource domain home - if the domain home is on a pv (we have a switch for this), then the default domain home path will be /shared/domains/<domain-uid> (instead of /shared/domain) log home - the default will be /shared/logs/<domain-uid> (instead of /shared/logs)
  3. this has implications on the create domain samples today we have one sample for creating the pv and other samples to put a domain home on the pv. they currently put the domain uid in the pv name (i.e. encourage one domain per pv). instead, we should modify the sample for creating the pv to not put the domain uid in its name. if a tire kicking customer wants one pv per domain, then they just run the sample to create the pv, and then a sample to create the domain home - they don't change any of the input values. if the customer want to add more sample domains to the sample pv, then the customer just runs the create domain sample script again, passing in an inputs file that changes the domain uid
  4. use case wiki (that I'm working on) - I'll separate out the use cases for creating the pvs from the use cases for creating domains that use them.

@anpanigr @vanajamukkara @maggiehe00

doxiao added 19 commits October 15, 2018 09:05
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID.

Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID.

Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…oracle/weblogic-kubernetes-operator into improve_samples_OOTB_experience

Signed-off-by: doxiao <dongbo.xiao@oracle.com>

Conflicts:
	kubernetes/samples/scripts/create-weblogic-domain-pv-pvc/create-pv-pvc.sh
	kubernetes/samples/scripts/create-weblogic-domain-pv-pvc/pv-template.yaml
	kubernetes/samples/scripts/create-weblogic-domain-pv-pvc/pvc-template.yaml
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
@doxiao doxiao changed the title Improve samples ootb experience WIP Improve samples ootb experience Oct 23, 2018
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
@vanajamukkara
Copy link
Member

Please see the note, this change has to wait until the intermittent issue is resolved.
Note: currently there is an intermittent issue in the integration test with the changes.

@tbarnes-us
Copy link

The overall change LGTM.

I'm OK with it is now, but wonder if there should be additional discussion about:

  • Whether the 's' should be added to /shared/domain to make it /shared/domains. I just don't recall there was general agreement there.
  • Whether a sample domain-home path should end with the domain-uid or with domain-uid/domain-name. The WL convention seems to be that the top level directory of a domain tends to match the domain name. I know it seems redundant, but I wonder if we should keep doing it for clarity? In this change /shared/domain/ becomes /shared/domain/<domain-uid>/<domain-name>. OTOH, we hope to someday provide the ability to override the domain-name, in which case it'd be confusing to put the name in the path...

@doxiao
Copy link
Member Author

doxiao commented Oct 23, 2018

The overall change LGTM.

I'm OK with it is now, but wonder if there should be additional discussion about:

* Whether the 's' should be added to /shared/domain to make it /shared/domains.   I just don't recall there was general agreement there.

See the newly added notes in the description.

* Whether a sample domain-home path should end with the domain-uid or with domain-uid/domain-name.   The WL convention seems to be that the top level  directory of a domain tends to match the domain name.   I know it seems redundant, but I wonder if we should keep doing it for clarity?  In this change /shared/domain/ becomes /shared/domain/<domain-uid>/<domain-name>.   OTOH, we hope to someday provide the ability to override the domain-name, in which case it'd be confusing to put the name in the path...

Just to be clear. The change in this PR defaults the domain home to /shared/domains/domainUID (no /domainName). I believe you are proposing adding /domainName to the path. I believe that this has been brought up and discarded in the slack channel when the proposal (in the description) was discussed.

@doxiao doxiao requested a review from tbarnes-us October 23, 2018 18:45
doxiao added 11 commits October 25, 2018 07:14
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID.

Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
@doxiao doxiao changed the title Improve samples ootb experience WIP Improve samples ootb experience Oct 25, 2018
@doxiao
Copy link
Member Author

doxiao commented Oct 25, 2018

There are problems after sync up with the latest develop branch. Looking.

doxiao added 10 commits October 25, 2018 08:24
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…/shared/domains/domainUID.

Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
…oracle/weblogic-kubernetes-operator into improve_samples_OOTB_experience

Conflicts:
	integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java
Signed-off-by: doxiao <dongbo.xiao@oracle.com>
@doxiao doxiao changed the title WIP Improve samples ootb experience Improve samples ootb experience Oct 25, 2018
@doxiao
Copy link
Member Author

doxiao commented Oct 25, 2018

There are problems after sync up with the latest develop branch. Looking.

The new issue in integration test has been resolved.

@doxiao doxiao changed the title Improve samples ootb experience Support custom PVC, default domain home and default log home Oct 25, 2018
…ation test with WDT

Signed-off-by: doxiao <dongbo.xiao@oracle.com>
@doxiao
Copy link
Member Author

doxiao commented Oct 25, 2018

Passed the full Java integration test locally and on Jenkins http://****/job/weblogic-kubernetes-operator-javatest/224/.

@rjeberhard rjeberhard merged commit ceadd59 into develop Oct 27, 2018
@rjeberhard rjeberhard deleted the improve_samples_OOTB_experience branch December 15, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants