Skip to content

OWLS-101923 fix integration test code in cluster-reference #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

doxiao
Copy link
Member

@doxiao doxiao commented Sep 1, 2022

The test performs the following:

  1. modify the WebLogic domain to increase the cluster size;
  2. patch the domain resource to have a new introspectVersion;
  3. patch the cluster resource to increase its replica count.

Step#3 fails because the operator has not completed the re-introspection caused by step #2, and therefore, the new cluster size is not reflected in the cluster's status.

The fix is to wait for the cluster's status is updated before proceeding to step#3.

The failing test case passed with the changes (https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/12590/ ).

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@doxiao doxiao changed the title OWLS-101923 Wait for introspectVersion patch processed before change cluster replicas OWLS-101923 fix integration test code Sep 1, 2022
@doxiao doxiao marked this pull request as ready for review September 1, 2022 19:19
@doxiao doxiao changed the title OWLS-101923 fix integration test code OWLS-101923 fix integration test code in cluster-reference Sep 1, 2022
Copy link
Member

@sankarpn sankarpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjeberhard rjeberhard merged commit 2c88462 into cluster-reference Sep 2, 2022
@rjeberhard rjeberhard deleted the OWLS101923-fix-test branch September 2, 2022 16:37
Copy link
Member

@vanajamukkara vanajamukkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants