Skip to content

OWLS-95390 - Add validation check to reject domain configurations that use same serverNamePrefix for multiple clusters. #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

ankedia
Copy link
Member

@ankedia ankedia commented Jan 6, 2022

Added a validation check in the introspector WLST script to reject the WebLogic configurations that attempt to use same server prefix name for more than one dynamic clusters.

Integration test run - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/7720/console

… uses same serverNamePrefix for multiple clusters.
Copy link

@tbarnes-us tbarnes-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbarnes-us
Copy link

tbarnes-us commented Jan 6, 2022

Minor: Please add a description of changes in the pull descriptoin (this helps when updating the release notes, since release notes are listed by pull# and "owls" JIRAs are only available internally).
Changed.

@ankedia
Copy link
Member Author

ankedia commented Jan 7, 2022

Integration test run had 4 failures - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/7720/ . The 3 test failures are not related to this change. I ran the ItKubernetesEvents test separately and it passed - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/7731 . I think this PR is ready to merge. Thanks.

@robertpatrick robertpatrick merged commit 4146b32 into main Jan 7, 2022
@robertpatrick robertpatrick deleted the owls_95390 branch January 7, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants