OWLS-90888 added negative AI test: Error path due File Permission issue #2463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinakog
requested review from
anpanigr,
bhavaniravichandran,
vanajamukkara and
sankarpn
anpanigr
reviewed
Jul 19, 2021
integration-tests/src/test/resources/auxiliaryimage/negative/Dockerfile
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Outdated
Show resolved
Hide resolved
rjeberhard
approved these changes
Jul 20, 2021
sankarpn
suggested changes
Jul 20, 2021
| * Negative Test to create domain with file , created by user tester with permission read only | ||
| * and not accessible by oracle user in auxiliary image | ||
| * via provided Dockerfile. | ||
| * Check the error msg is in introspector pod log, domain events and operator pod log. |
There was a problem hiding this comment.
Suggested change
| * Check the error msg is in introspector pod log, domain events and operator pod log. | |
| * Check the error message is in introspector pod log, domain events and operator pod log. |
|
|
||
| // create stage dir for auxiliary image | ||
| Path errorpathAIPath1 = Paths.get(RESULTS_ROOT, "errorpathauxiimage4"); | ||
| assertDoesNotThrow(() -> FileUtils.deleteDirectory(errorpathAIPath1.toFile())); |
There was a problem hiding this comment.
Please assert failure messages in all asserts below.
| // push image to repo for multi node cluster | ||
| if (!DOMAIN_IMAGES_REPO.isEmpty()) { | ||
| logger.info("docker push image {0} to registry {1}", errorPathAuxiliaryImage1, DOMAIN_IMAGES_REPO); | ||
| assertTrue(dockerPush(errorPathAuxiliaryImage1), |
There was a problem hiding this comment.
I guess you need to use dockerLoginAndPushImageToRegistry() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a file on the source image that cannot be accessed by the oracle user, check error in introspector
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5711/