Feature gates #2361
Merged
Feature gates #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to create a reusable feature gating functionality that lets us check in other features (e.g. common mounts) into the
mainbranch prior to that other feature being ready for release. For instance, the feature may lack documentation or a complete set of integration tests.The goal is to preserve our ability to release the main branch as a bug-fix release at any time and not have to resort to backports to a previous release branch.
The customer can then enable a feature as part of the Helm install for the operator, which is also the pattern that we will follow in our integration tests. Sometime later, the specific feature can either be set to be enabled by default or the checks for the feature gate can be removed.
The feature gating functionality includes a Helm value where the customer (or test cases) can enable a feature, an annotation that can be used on fields in our model classes to designate them as related to the feature, and API's to check if a given feature is enabled prior to invoking feature-related code paths.
Note: I also cleaned up a few spelling errors and removed a few unused strings in the message bundle.