Added tests to use script scaleCluster.sh/ClusterStatus.sh #2350
Conversation
|
|
||
| // restore test env | ||
| result = assertDoesNotThrow(() -> | ||
| executeLifecycleScript(STOP_SERVER_SCRIPT, SERVER_LIFECYCLE, configServerName), |
There was a problem hiding this comment.
Can you use the same script scaleCluster.sh to scale down the cluster instead of stopServer.sh script
There was a problem hiding this comment.
good idea. Wii change
|
|
||
| // restore test env | ||
| logger.info("Stop managed server using the script"); | ||
| executeLifecycleScript(STOP_SERVER_SCRIPT, SERVER_LIFECYCLE, dynamicServerName); |
There was a problem hiding this comment.
Can you use the same script scaleCluster.sh to scale down the cluster instead of stopServer.sh script
| executeLifecycleScript(STATUS_CLUSTER_SCRIPT, CLUSTER_LIFECYCLE, CLUSTER_2), | ||
| String.format("Failed to run %s", STATUS_CLUSTER_SCRIPT)); | ||
|
|
||
| String regex = ".*" + CLUSTER_2 + "(\\s+)0(\\s+)2(\\s+)2(\\s+)2(\\s+)2"; |
There was a problem hiding this comment.
It would help me to have a comment describing what this regex is intended to match.
There was a problem hiding this comment.
Just to clarify... I'm looking for a description of the regex expression specifically. What is it intended to match? If someday this test failed and we needed to fix the regex expression I would want to know what it's supposed to match so I could figure out if it is correct.
There was a problem hiding this comment.
added more clearer descriptions
| // String regex matches below | ||
| // cluster min max goal current ready | ||
| // clusterName 1 5 1 1 1 | ||
| String regex = ".*" + CLUSTER_1 + "(\\s+)1(\\s+)5(\\s+)1(\\s+)1(\\s+)1"; |
There was a problem hiding this comment.
What call returns the formatted data given above? I can see how the regex matches this, but this seems really brittle.
There was a problem hiding this comment.
I see it's from clusterStatus.sh... Okay, I guess that's what we have to test.
usecase:
Scale the configured/dynamic cluster using the sample script scaleCluster.sh script
Verify that server(s) in the configured/dynamic cluster are scaled up and in RUNNING state.
Verify that server(s) in the dynamic/configured cluster are not affected.
Restore the env
Jenkins job:
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4934 (parallel)
Passed Jenkins job with latest changes
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4954 (parallel)