Skip to content

Owls88611 make sure REST calls are made using the expected port and protocol #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 13, 2021
Merged
Prev Previous commit
Next Next commit
modify unit test cases to make their logic more clear
  • Loading branch information
doxiao committed Apr 9, 2021
commit a8434ad275ecd72f3b34a7ec4350915f7cc806f5
Original file line number Diff line number Diff line change
Expand Up @@ -280,79 +280,113 @@ public void whenUnableToReadHealth_verifyNotAvailable() {
}

@Test
public void whenReadDynamicManagedServerHealthWithServerListenPortOnly_decrementRemainingServers() {
public void whenServerConfiguredWithServerListenPortOnly_readHealthUsingServerListenPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setListenPort(8001);
defineResponse(200, "", "http://dyn-managed-server2.Test:8001");
defineExpectedURLInResponse("http", 8001);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(getRemainingServersToRead(packet), equalTo(0));
assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenServerConfiguredWithSSLPortOnly_readHealthUsingSSLPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setSslListenPort(7002);
defineExpectedURLInResponse("https", 7002);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenReadDynamicManagedServerHealthWithServerListenPortAndSSLPort_decrementRemainingServers() {
public void whenServerConfiguredWithServerListenPortAndSSLPort_readHealthUsingSSLPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setListenPort(8001);
server.setSslListenPort(7002);
defineResponse(200, "", "https://dyn-managed-server2.Test:7002");
defineExpectedURLInResponse("https", 7002);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(getRemainingServersToRead(packet), equalTo(0));
assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenReadDynamicManagedServerHealthWithServerListenPortAndNAP_decrementRemainingServers() {
public void whenServerConfiguredWithServerListenPortAndNonAdminNAP_readHealthUsingServerListenPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setListenPort(8001);
server.addNetworkAccessPoint(new NetworkAccessPoint("nap1", "t3", 9001, 9001));
defineResponse(200, "", "http://dyn-managed-server2.Test:8001");
defineExpectedURLInResponse("http", 8001);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(getRemainingServersToRead(packet), equalTo(0));
assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenReadDynamicManagedServerHealthWithServerSSLPortAndNAP_decrementRemainingServers() {
public void whenServerConfiguredWithServerSSLPortAndNonAdminNAP_readHealthUsingSSLPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setSslListenPort(7002);
server.addNetworkAccessPoint(new NetworkAccessPoint("nap1", "t3", 9001, 9001));
defineResponse(200, "", "https://dyn-managed-server2.Test:7002");
defineExpectedURLInResponse("https", 7002);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(getRemainingServersToRead(packet), equalTo(0));
assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenReadDynamicManagedServerHealthWithAdminNAPOnly_decrementRemainingServers() {
public void whenServerConfiguredWithSSLPortAndAdminNAP_readHealthUsingAdminNAPPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setSslListenPort(7002);
server.addNetworkAccessPoint(new NetworkAccessPoint("admin", "admin", 8888, 8888));
defineResponse(200, "", "https://dyn-managed-server2.Test:8888");
defineExpectedURLInResponse("https", 8888);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(getRemainingServersToRead(packet), equalTo(0));
assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenReadDynamicManagedServerHealthWithNonAdminNAPOnly_decrementRemainingServers() {
public void whenServerConfiguredWithServerListenPortAndAdminNAP_readHealthUsingAdminNAPPort() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.setListenPort(8001);
server.setListenPort(null);
server.addNetworkAccessPoint(new NetworkAccessPoint("nap1", "admin", 8888, 8888));
defineExpectedURLInResponse("https", 8888);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(readServerHealthSucceeded(packet), equalTo(true));
}

@Test
public void whenServerConfiguredWithNonAdminNAPOnly_readHealthFailed() {
selectServer(DYNAMIC_MANAGED_SERVER2, headlessMSService);
WlsServerConfig server = getDynamicClusterServer2();
server.addNetworkAccessPoint(new NetworkAccessPoint("nap1", "t3", 9001, 9001));
defineResponse(200, "", "http://dyn-managed-server2.Test:7001");
defineExpectedURLInResponse("http", 9001);

Packet packet = testSupport.runSteps(readHealthStep);

assertThat(getRemainingServersToRead(packet), equalTo(0));
assertThat(readServerHealthSucceeded(packet), equalTo(false));
}

private void defineExpectedURLInResponse(String protocol, int port) {
defineResponse(200, "", protocol + "://dyn-managed-server2.Test:" + port);
}

private boolean readServerHealthSucceeded(Packet packet) {
return getRemainingServersToRead(packet) == 0;
}

private WlsServerConfig getDynamicClusterServer2() {
Expand Down