OWLS-83537 - Update domain home in image samples to use WIT instead of docker-images samples #2290

alai8 · 2021-03-30T16:03:07Z

Update domain home in image samples under both create-weblogic-domain and create-fmw-infrastructure-domain to use WebLogic Image tool to create domain in image instead of using https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples.

Both WDT model and offline WLST scripts to create the WebLogic domain are supported.

Fix create-fmw-infrastructure-domain/domain-home-on-pv when configured to use WDT to create the domain home.

Add missing documentation for FMW Infrastructure Domain Home in Image sample.

Update ItFmwSample test to test both wdt and wlst for domain on pv

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4933/

…t with image tool for domain creation

…or creating domain with image

…rastructure-domain doamin-in-image

…ubernetes-operator into update-samples

...ples/scripts/create-fmw-infrastructure-domain/domain-home-in-image/create-domain-inputs.yaml

…ption

…image samples

tbarnes-us

Looks quite nice to me. I've posted a couple more minor doc comments.

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md

documentation/staging/content/samples/simple/domains/fmw-domain-home-in-image/_index.md

...ples/scripts/create-fmw-infrastructure-domain/domain-home-in-image/create-domain-inputs.yaml

...netes/samples/scripts/create-fmw-infrastructure-domain/domain-home-in-image/create-domain.sh

...amples/scripts/create-fmw-infrastructure-domain/domain-home-in-image/wlst/createFMWDomain.sh

ddsharpe · 2021-05-06T00:19:29Z

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md

@@ -5,15 +5,15 @@ weight: 3
 description: "Sample for creating a WebLogic domain home inside an image, and the Domain YAML file for deploying the generated WebLogic domain."
 ---

-The sample scripts demonstrate the creation of a WebLogic domain home in an image using one of the domain home in image samples in the Oracle WebLogic Server images [GitHub project](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples). The sample scripts have the option of putting the WebLogic domain log, server logs, server output files, and the Node Manager logs on an existing Kubernetes PersistentVolume (PV) and PersistentVolumeClaim (PVC). The scripts also generate the domain YAML file, which can then be used by the scripts or used manually to start the Kubernetes artifacts of the corresponding domain, including the WebLogic Server pods and services.
+The sample scripts demonstrate the creation of a WebLogic domain home in an image using [WebLogic Image Tool](https://github.com/oracle/weblogic-image-tool) (WIT). The sample scripts have the option of putting the WebLogic domain log, server logs, server output files, and the Node Manager logs on an existing Kubernetes PersistentVolume (PV) and PersistentVolumeClaim (PVC). The scripts also generate the domain YAML file, which can then be used by the scripts or used manually to start the Kubernetes artifacts of the corresponding domain, including the WebLogic Server pods and services.


...generate the domain YAML file... => ...generate the domain resource YAML file...
We need to differentiate between the domain YAML that WDT uses and the domain YAML that the Operator uses. I would like to start referring to the YAML that the Operator uses as the domain resource, but open to other suggestions.

ddsharpe · 2021-05-06T00:34:36Z

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md


 #### Prerequisites

 Before you begin, read this document, [Domain resource]({{< relref "/userguide/managing-domains/domain-resource/_index.md" >}}).

 The following prerequisites must be met prior to running the create domain script:

-* The WebLogic Deploy Tooling (WDT) sample requires that `JAVA_HOME` is set to a Java JDK version 1.8 or later.
+* The WebLogic Image Tool requires that `JAVA_HOME` is set to a Java JDK version 8 or later.
 * The operator requires either Oracle WebLogic Server 12.2.1.3.0 with patch 29135930 applied, or Oracle WebLogic Server 12.2.1.4.0, or Oracle WebLogic Server 14.1.1.0.0. The existing WebLogic Server image, `container-registry.oracle.com/middleware/weblogic:12.2.1.3`, has all the necessary patches applied. For details on how to obtain or create the image, see [WebLogic Server images]({{< relref "/userguide/base-images/_index.md#create-or-obtain-weblogic-server-images" >}}).


I think you meant to say "The operator requires an image with either Oracle WebLogic Server 12.2.1.3...."

ddsharpe · 2021-05-06T00:58:53Z

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md

+Use the following command to delete an image tagged with `domain-home-in-image:12.2.1.4`:
+
+```shell
+$ docker rmi domain-home-in-image:12.2.1.4


This only deletes the local image. Are you assuming that the k8s cluster is running locally, and that the image is only local?

I am assuming the image is local. Should we modify to something like the following?

+When no longer needed, delete the generated image.
+If the image in in a local repository, use the following command to delete an image tagged with domain-home-in-image:12.2.1.4:

documentation/staging/content/samples/simple/domains/fmw-domain-home-in-image/_index.md

tbarnes-us · 2021-05-12T20:42:55Z

LGTM, I've approved, but do have one last general comment:

The Quick Start sample documentation does not mention that the createDomain.sh script implicitly downloads and uses WIT and WDT under /tmp/(inputs toolsDir). This is important and somewhat surprising behavior for a new user IMO.

So I think it'd help significantly to summarize the information in the domain-in-image's "The script will perform the following steps:" bullet list directly in the Quick Start documentation itself, just before the current Quick Start wording "For the detailed steps that the create-domain.sh script performs, see Domain Home In Image." Alternatively, reword the latter sentence to be less anodyne (highly encourage the reader to click through the link).

This would make the behavior of createDomain.sh much less of a mystery to new users, who, I think, aren't necessarily likely to click through the 'detailed steps' link.

rosemarymarano

Great, thanks.

rosemarymarano · 2021-05-14T14:43:39Z

Took your suggestion. See #2360

sankarpn

LGTM

alai8 added 30 commits February 5, 2021 21:15

create common wdt-utility.sh

073963f

use wdt

7cfccb8

correct argument

a7634c4

run_wdt supports domain_type arg

cacdc7f

Merge branch 'develop' into update-samples

75e633a

modify domain-home-in-image to use WIT to create image with domain

f72cc1e

fix defaulting wdt and wit versions when not specified in input file

ad1de46

de-parameterized testSampleDomainInImage since we replace wdt and wls…

260b337

…t with image tool for domain creation

create secret if not exist in testSampleDomainInPv

7c8d518

minor cleanup domain-home-in-image scripts

0237356

update fmw domain home in image sample to use wit instead of docker f…

50bc3c8

…or creating domain with image

revert changes

3167adb

update domain-home-in-image sample doc with WIT

b3cc84f

more WIT related changes to samples docs

eb04269

make wdt and wit install dir customizable

039baa1

update comments and doc for toolsDir

7a1d40c

uses different model depends on fmwDomainType in create-domai-fmw-inf…

0fd273f

…rastructure-domain doamin-in-image

Merge branch 'develop' into update-samples

afa55d9

Merge branch 'update-samples' of https://github.com/oracle/weblogic-k…

7090be2

…ubernetes-operator into update-samples

rename topology.yaml to wdt_model_dynamic.yaml

8bfe127

use https_proxy to download zip files if set

0b2aa64

add https_proxy env to create domain job

78195dc

add https_proxy env to create domain job

73fe777

need to call extractDomainResource.sh for wdt

3daaaf5

doc update

424f66c

remove -k option in create-domain.sh for domain-home-in-image samples

46f5bf5

Merge branch 'develop' into update-samples

82fd4d6

doc updates

e92e773

domain-home-in-image samples doc update

1d9e5a9

remove debug outputs

d010401

replace -m wlst with mode: wlst in input file

197ba32

tbarnes-us reviewed May 3, 2021

View reviewed changes

...ples/scripts/create-fmw-infrastructure-domain/domain-home-in-image/create-domain-inputs.yaml Outdated Show resolved Hide resolved

alai8 added 5 commits May 3, 2021 16:26

replace rcuSchemaPassword input parameters with -q create-domain.sh o…

cb4b47a

…ption

replace rcuSchemaPassword input parameters with -q create-domain.sh o…

02bd51d

…ption

add -q create-domain.sh to doc for fmw infrastructure domain home in …

9b4be17

…image samples

Merge branch 'main' into update-samples

c140b67

WebLogic Server Kubernetes Operator -> WebLogic Kubernetes Operator

8ea6c55

tbarnes-us approved these changes May 4, 2021

View reviewed changes

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md Outdated Show resolved Hide resolved

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md Outdated Show resolved Hide resolved

tbarnes-us reviewed May 4, 2021

View reviewed changes

documentation/staging/content/samples/simple/domains/domain-home-in-image/_index.md Outdated Show resolved Hide resolved

tbarnes-us reviewed May 4, 2021

View reviewed changes

documentation/staging/content/samples/simple/domains/fmw-domain-home-in-image/_index.md Outdated Show resolved Hide resolved

tbarnes-us reviewed May 4, 2021

View reviewed changes

alai8 and others added 3 commits May 5, 2021 01:02

do not echo password and other minor fixes per review comments

c8265aa

doc fixes

79de633

typo fix

e239da1

ddsharpe reviewed May 6, 2021

View reviewed changes

alai8 added 2 commits May 10, 2021 09:36

fixed typos

f80d782

Merge branch 'main' into update-samples

342bc8c

sankarpn reviewed May 10, 2021

View reviewed changes

documentation/staging/content/samples/simple/domains/fmw-domain-home-in-image/_index.md Show resolved Hide resolved

alai8 added 3 commits May 11, 2021 11:25

samples doc update per review comments

969496b

remove quotes from --tag

a0b3f11

typo

ba1ddbc

This comment has been minimized.

Sign in to view

tbarnes-us approved these changes May 12, 2021

View reviewed changes

update urls to doc sites for wdt and wit

715f227

rosemarymarano approved these changes May 13, 2021

View reviewed changes

sankarpn approved these changes May 14, 2021

View reviewed changes

rjeberhard merged commit 1b7e236 into main May 17, 2021

alai8 deleted the update-samples branch May 19, 2021 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OWLS-83537 - Update domain home in image samples to use WIT instead of docker-images samples #2290

OWLS-83537 - Update domain home in image samples to use WIT instead of docker-images samples #2290

Uh oh!

alai8 commented Mar 30, 2021 •

edited

Loading

Uh oh!

Uh oh!

tbarnes-us left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddsharpe May 6, 2021

Uh oh!

ddsharpe May 6, 2021

Uh oh!

ddsharpe May 6, 2021

Uh oh!

alai8 May 6, 2021

Uh oh!

Uh oh!

This comment has been minimized.

tbarnes-us commented May 12, 2021 •

edited

Loading

Uh oh!

rosemarymarano left a comment

Uh oh!

rosemarymarano commented May 14, 2021

Uh oh!

sankarpn left a comment

Uh oh!

Uh oh!

OWLS-83537 - Update domain home in image samples to use WIT instead of docker-images samples #2290

OWLS-83537 - Update domain home in image samples to use WIT instead of docker-images samples #2290

Uh oh!

Conversation

alai8 commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tbarnes-us left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddsharpe May 6, 2021

Choose a reason for hiding this comment

Uh oh!

ddsharpe May 6, 2021

Choose a reason for hiding this comment

Uh oh!

ddsharpe May 6, 2021

Choose a reason for hiding this comment

Uh oh!

alai8 May 6, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

tbarnes-us commented May 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rosemarymarano left a comment

Choose a reason for hiding this comment

Uh oh!

rosemarymarano commented May 14, 2021

Uh oh!

sankarpn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alai8 commented Mar 30, 2021 •

edited

Loading

tbarnes-us commented May 12, 2021 •

edited

Loading