address review comments

operator/src/main/java/oracle/kubernetes/operator/http/HttpAsyncRequestStep.java

@@ -8,7 +8,6 @@
 import java.net.http.HttpClient;
 import java.net.http.HttpRequest;
 import java.net.http.HttpResponse;
-import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.TimeUnit;
 
@@ -107,15 +106,14 @@ private void checkTimeout(AsyncFiber fiber) {
     }
 
     private void resume(AsyncFiber fiber, HttpResponse<String> response, Throwable throwable) {
-      if (throwable != null) {
-        if (throwable instanceof HttpTimeoutException) {
-          LOGGER.fine(MessageKeys.HTTP_REQUEST_TIMED_OUT, throwable.getMessage());
-        } else if (response == null) {
-          recordThrowableResponse(throwable);
-        }
+      if (throwable instanceof HttpTimeoutException) {
+        LOGGER.fine(MessageKeys.HTTP_REQUEST_TIMED_OUT, throwable.getMessage());
+      } else if (response != null) {
+        recordResponse(response);
+      } else if (throwable != null) {
+        recordThrowableResponse(throwable);
       }
-
-      Optional.ofNullable(response).ifPresent(this::recordResponse);
+
       fiber.resume(packet);
     }
 

operator/src/main/java/oracle/kubernetes/operator/http/HttpResponseStep.java

@@ -23,9 +23,13 @@ public HttpResponseStep(Step next) {
   public NextAction apply(Packet packet) {
     return Optional.ofNullable(getResponse(packet))
         .map(r -> doApply(packet, r))
-        .orElse(Optional.ofNullable(getThrowableResponse(packet))
-            .map(t -> onFailure(packet, null))
-            .orElse(doNext(packet)));
+        .orElse(handlePossibleThrowableOrContinue(packet));
+  }
+
+  private NextAction handlePossibleThrowableOrContinue(Packet packet) {
+    return Optional.ofNullable(getThrowableResponse(packet))
+        .map(t -> onFailure(packet, null))
+        .orElse(doNext(packet));
   }
 
   private Throwable getThrowableResponse(Packet packet) {

operator/src/test/java/oracle/kubernetes/operator/http/HttpAsyncRequestStepTest.java

@@ -128,16 +128,14 @@ public void whenErrorResponseReceived_logMessage() {
 
   @Test
   public void whenThrowableResponseReceived_logMessage() {
-    Memento m = TestUtils.silenceOperatorLogger()
+    consoleMemento
         .collectLogMessages(logRecords, HTTP_REQUEST_GOT_THROWABLE)
-        .withLogLevel(Level.WARNING)
-        .ignoringLoggedExceptions(HttpAsyncRequestStep.HttpTimeoutException.class);
+        .withLogLevel(Level.WARNING);
     final NextAction nextAction = requestStep.apply(packet);
 
     completeWithThrowableBeforeTimeout(nextAction, new Throwable("Test"));
 
     assertThat(logRecords, containsWarning(HTTP_REQUEST_GOT_THROWABLE));
-    m.revert();
   }
 
   @Test