Update unit tests and simplify logic for dynamic update #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeberhard
reviewed
Mar 2, 2021
| @@ -1520,6 +1590,13 @@ public void whenPodCreated_createPodWithOwnerReference() { | |||
| assertThat(getCreatedPod().getMetadata().getOwnerReferences(), contains(expectedReference)); | |||
| } | |||
|
|
|||
| // TODO: add tests for dynamic updates | |||
There was a problem hiding this comment.
How hard would it be to create these tests? I'm not a fan of leaving a TODO in the code.
There was a problem hiding this comment.
actually the tests are there, removing TODO
rjeberhard
approved these changes
Mar 2, 2021
|
There is regression in the branch, withdrawing now. |
…te the primordial domain.
|
I found the problem, actually it's a bug rather than a regression in mii v1 model diff code |
russgold
approved these changes
Mar 8, 2021
|
@jshum2479, what's the status of this change? Did you resolve the regression? |
|
@rjeberhard Actually, it's not a regression, I found a bug in v1 and fixed that. It should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Russ and I worked on adding unit tests and simplify the makeright logic for dynamic update.