OWLS 85938 - Server lifecycle script changes to use domain.status.minimumReplicas when stopping/starting server #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licas and minor bug fix.
rjeberhard
approved these changes
Nov 9, 2020
tbarnes-us
reviewed
Nov 9, 2020
| # check if replica count can decrease below current value | ||
| isReplicaCountEqualToMinReplicas "${domainJson}" "${clusterName}" replicasEqualsMinReplicas | ||
| if [ "${replicasEqualsMinReplicas}" == 'true' ]; then | ||
| printInfo "Current replica count value is same as minimum number of replica count. \ |
There was a problem hiding this comment.
Maybe provide a little more detail:
Not decreasing replica count: it is at its minimum. (See 'domain.spec.allowReplicasBelowMinDynClusterSize' and 'domain.status.clusters[].minimumReplicas' for details.)
There was a problem hiding this comment.
Changed the message in 6dae3f1. Please let me know if more details are needed.
|
Sorry, I had accidently deleted the branch which inadvertently closed the PR. |
tbarnes-us
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OWLS 85938 - Server lifecycle script changes to use
domain.status.minimumReplicaswhen allowReplicasBelowMinDynClusterSize is set tofalse. It also fixes a minor bug when setting server start policy to ALWAYS.This change adds a check in stop script to see if replica count value is same as minimum replica count value and prevents script from incorrectly assuming that decreasing the replica count would shut down a server. Additionally, when replica count value of cluster is lower than minimum replica count, it resets the replica count value to minimum replica count value. This helps server start script to know the value of effective replica count.