Adding application high availability check in operator upgrade tests #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add an Upgrade Test for Release 3.0.3 in this PR |
sankarpn
suggested changes
Nov 9, 2020
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItOperatorUpgrade.java
Outdated
Show resolved
Hide resolved
| appAccessedAfterUpgrade = true; | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
Is there a reason for the delay here?
There was a problem hiding this comment.
This can be removed as upgrade is not taking much time. This was added to introduce some delay if the other thread is going to take long time.
| @@ -169,7 +190,9 @@ public void testOperatorUpgradeFrom3_0_2(@Namespaces(3) List<String> namespaces) | |||
| */ | |||
| @AfterEach | |||
| public void tearDown() { | |||
| if (System.getenv("SKIP_CLEANUP") == null) { | |||
| if (System.getenv("SKIP_CLEANUP") == null | |||
| || (System.getenv("SKIP_CLEANUP") != null | |||
There was a problem hiding this comment.
what is the point of checking for both null and not null? If its null isn't it the next statement going to throw NPE?
…peratorUpgrade.java Co-authored-by: Sankar Periyathambi Neelakandan <45743425+sankarpn@users.noreply.github.com>
…logic-kubernetes-operator into highavailabilitytests
Added, here is the Jenkins results with 3.0.3 upgrade test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding application high availability check in operator upgrade tests.
An application is deployed to the cluster in the domain and the application is continuously accessed from a separate thread while the operator is being upgraded and after the upgrade.
This check is added only for operator releases 3.0.0 and later, Ryan confirmed this is not needed for older releases.
Jenkins results:
sequential run - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3056/
Just upgrade test - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3054/
Upgrade tests are not run in parallel