Added maven profile to run a set of integration tests for the new image certification #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanajamukkara
suggested changes
Oct 30, 2020
anpanigr
reviewed
Nov 3, 2020
vanajamukkara
suggested changes
Nov 3, 2020
kindtest.sh
Outdated
| @@ -73,6 +75,7 @@ parallel_run="false" | |||
| threads="2" | |||
| wdt_download_url="https://github.com/oracle/weblogic-deploy-tooling/releases/latest" | |||
| wit_download_url="https://github.com/oracle/weblogic-image-tool/releases/latest" | |||
| verify_image_run="false" | |||
There was a problem hiding this comment.
Suggested change
| verify_image_run="false" | |
| maven_profile_name="integration-tests" |
kindtest.sh
Outdated
| @@ -94,6 +97,8 @@ while getopts ":h:n:o:t:v:c:x:p:d:i:" opt; do | |||
| ;; | |||
| i) wit_download_url="${OPTARG}" | |||
| ;; | |||
| m) verify_image_run="${OPTARG}" | |||
There was a problem hiding this comment.
Suggested change
| m) verify_image_run="${OPTARG}" | |
| m) maven_profile_name="${OPTARG}" |
kindtest.sh
Outdated
| @@ -237,9 +242,19 @@ rm -rf "${RESULT_ROOT:?}/*" | |||
|
|
|||
| echo 'Run tests...' | |||
| if [ "${test_filter}" = "ItOperatorUpgrade" ] || [ "${parallel_run}" = "false" ]; then | |||
| echo "Running mvn -Dit.test=${test_filter} -Dwdt.download.url=${wdt_download_url} -Dwit.download.url=${wit_download_url} -pl integration-tests -P integration-tests verify" | |||
| time mvn -Dit.test="${test_filter}" -Dwdt.download.url="${wdt_download_url}" -Dwit.download.url="${wit_download_url}" -pl integration-tests -P integration-tests verify 2>&1 | tee "${RESULT_ROOT}/kindtest.log" | |||
| if [ "${verify_image_run}" != "verify-images-tests" ]; then | |||
There was a problem hiding this comment.
you don't need this condition, use ${maven_profile_name} in the mvn command
anpanigr
reviewed
Nov 6, 2020
kindtest.sh
Outdated
| test_filter="${test_filter_wls}" | ||
| elif [ "${maven_profile_name}" = "fmw-image-cert" ]; then | ||
| test_filter="${test_filter_fmw}" | ||
| fi |
There was a problem hiding this comment.
if (maven_profile_name) is not defined (the current behaviour) what path it should follows ? It should default to current behavior where it does not take any maven profile.
There was a problem hiding this comment.
default is test_filter="**/It*" in line 72
vanajamukkara
suggested changes
Nov 6, 2020
kindtest.sh
Outdated
| @@ -68,13 +70,16 @@ else | |||
| outdir="${WORKSPACE}/logdir/${BUILD_TAG}" | |||
| fi | |||
| test_filter="**/It*" | |||
| test_filter_wls="**/ItParameterizedDomain.java,**/ItServerStartPolicy.java,**/ItMiiUpdateDomainConfig.java,**/ItIntrospectVersion.java,**/ItMiiSample.java,**/ItJrfDomainInPV.java,**/ItStickySession.java,**/ItSessionMigration.java" | |||
There was a problem hiding this comment.
these are defined in the profile, you don't have to set here
added 2 commits
November 6, 2020 17:46
|
Can u run the test once in https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new to make sure it does not break the existing jenkin configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this set of tests added to the new maven profile
ItParameterizedDomain.java
ItServerStartPolicy.java
ItMiiUpdateDomainConfig.java
ItIntrospectVersion.java
ItMiiSample.java,
ItJrfDomainInPV.java,
ItStickySession.java
ItSessionMigration.java
based on the QA wiki:
http://aseng-wiki.****/asengwiki/display/WLSQA/WebLogic+Kubernetes+Operator+Certification
Jenkins job passed
parallel + fmw-image-cert
https://build.weblogick8s.org:8443/job/wko-tmp/92
parallel + wls-image-cert
https://build.weblogick8s.org:8443/job/wko-tmp/95/
parallel + integration-tests
https://build.weblogick8s.org:8443/job/wko-tmp/94/