-
Notifications
You must be signed in to change notification settings - Fork 217
OWLS 84741: Scaling failed on Jenkins when setting Dedicated to true & io.kubernetes.client.openapi.ApiException: Not Found #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6065ec9
9af2a9c
3cbf213
43c8e0e
23294da
d7f774a
ba8a35a
8a8dad5
6e1df5a
086f167
bf48df1
67d8500
245e0fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -191,3 +191,13 @@ externalServiceNameSuffix: "-ext" | |
# cluster size. | ||
# The default value is true. | ||
clusterSizePaddingValidationEnabled: true | ||
|
||
# tokenReviewAuthentication, if set to true, specifies whether the the operator's REST API should use | ||
# 1. Kubernetes token review API for authenticating users, and | ||
# 2. Kubernetes subject access review API for authorizing a user's operation (get, list, | ||
# patch, etc) on a resource. | ||
# 3. Update the Domain resource using the operator's privileges. | ||
# This parameter, if set to false, will use the caller's bearer token for any update | ||
# to the Domain resource so that it is done using the caller's privileges. | ||
# The default value is false. | ||
#tokenReviewAuthentication: false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "The default value is false." would be a good thing to note. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This leaves ambiguous the meaning of "false." Would you please update this to describe that when the value is false that the caller's bearer token will be delegated so that the update to the Domain resource is done using the caller's privileges? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated with description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are adding a required role verb (this seems correct), but reminds me that we need to document this requirement in the scaling and/or RBAC documentation. Similarly, we need to document how to create the correct roles and role bindings so that the service account used with the scaling API has the necessary permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated documentation in /userguide/managing-operators/using-the-operator/using-helm.md, /userguide/managing-operators/using-the-operator/the-rest-api.md, /userguide/managing-domains/domain-lifecycle/scaling.md, and /kubernetes/charts/weblogic-operator/values.yaml