Skip to content

Revert backofflimit check #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Revert backofflimit check #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9161c
revert backoff limit check
ankedia Aug 5, 2020
11bd8ac
ignore unit test for backoff limit check
ankedia Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions operator/src/main/java/oracle/kubernetes/operator/JobWatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,7 @@ void updatePacket(Packet packet, V1Job job) {
// be available for reading
@Override
boolean shouldTerminateFiber(V1Job job) {
return isFailed(job) && ("DeadlineExceeded".equals(getFailedReason(job))
|| "BackoffLimitExceeded".equals(getFailedReason(job)));
return isFailed(job) && ("DeadlineExceeded".equals(getFailedReason(job)));
}

// create an exception to terminate the fiber
Expand Down
2 changes: 2 additions & 0 deletions operator/src/test/java/oracle/kubernetes/operator/JobWatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import oracle.kubernetes.weblogic.domain.model.Domain;
import org.joda.time.DateTime;
import org.junit.After;
import org.junit.Ignore;
import org.junit.Test;

import static oracle.kubernetes.operator.LabelConstants.CREATEDBYOPERATOR_LABEL;
Expand Down Expand Up @@ -234,6 +235,7 @@ public void whenWaitForReadyAppliedToTimedOutJobWithDeadlineExceeded_terminateWi
}

@Test
@Ignore
public void whenWaitForReadyAppliedToTimedOutJobWithBackoffLimitExceeded_terminateWithException() {
startWaitForReady(job -> markJobTimedOut(job, "BackoffLimitExceeded"));

Expand Down