update the JAVA_URL in Dockerfiles #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markxnelson
reviewed
Jul 20, 2020
There was a problem hiding this comment.
seems a bit unreliable. maybe we should first get this page https://jdk.java.net/14/
then scan for the link that contains this openjdk-14.0.2_linux-x64_bin.tar.gz
I don't know how often these change, but it does not seem like we want to be updating it manually every time they build
|
@markxnelson we just need this change right now so that the tests can build the Operator image and pass. Later we will create a PR to automate the lookup of the JAVA URL. |
mriccell
approved these changes
Jul 20, 2020
ddsharpe
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest openjdk build is 12. Change Dockefile to set the correct JAVA_URL:
ENV JAVA_URL https://download.java.net/java/GA/jdk14.0.2/205943a0976c4ed48cb16f1043c5c647/12/GPL/openjdk-14.0.2_linux-x64_bin.tar.gz