Improve test verification #1777
Conversation
doxiao
commented
Jun 30, 2020
doxiao
commented
- In ItMiiDomain testPatchAppV2 test case, stop the application availability thread when it detects a failure, instead of waiting for the patched application is accessible on all managed servers.
- In ItOperatorRestartWhenPodRoll test case, check and wait for the operator pod to be restarted, instead of, ready to close a window between async deletion of the operator and check for podIsReady.
| @@ -1074,6 +1075,7 @@ private static void collectAppAvaiability( | |||
|
|
|||
| if (count == 0) { | |||
| logger.info("XXXXXXXXXXX: application not available XXXXXXXX"); | |||
| failed = true; | |||
There was a problem hiding this comment.
This is an odd programming style. Why not use break?
There was a problem hiding this comment.
Related question... why aren't you using our ordinary retry pattern?
There was a problem hiding this comment.
This is an odd programming style. Why not use break?
Yes, actually I can just exit the loop with break.
There was a problem hiding this comment.
Related question... why aren't you using our ordinary retry pattern?
Did you mean using ConditionFactory?
There was a problem hiding this comment.
The pattern that we use in the JUnit5 test cases are easier for a simple condition retries. Here we have additional operation to perform. So I did not think that was a better pattern for this.
...integration-tests/src/test/java/oracle/weblogic/kubernetes/ItOperatorRestartWhenPodRoll.java
Show resolved
Hide resolved
| @@ -1074,6 +1074,7 @@ private static void collectAppAvaiability( | |||
|
|
|||
| if (count == 0) { | |||
| logger.info("XXXXXXXXXXX: application not available XXXXXXXX"); | |||
There was a problem hiding this comment.
What are the "XXX" and "YYY"? What application is it?
There was a problem hiding this comment.
Those "XXX" and "YYY" are tokens to make it easier for people to notice the failure/healthy conditions. The failure case "XXX" is INFO, and "YYY" is "FINE".
