Istiocdxaction #1771

bhavaniravichandran · 2020-06-26T15:36:16Z

Test to confirm cross domain transaction works when istio is enabled.

sankarpn · 2020-06-26T16:14:27Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+@DisplayName("Verify cross domain transaction with istio enabled is successful")
+@IntegrationTest
+public class ItIstioCrossDomainTransaction implements LoggedTest {


no more implements LoggedTest
Please see PR #1765
Now you need to get logger here and initialize it in initAll method.

private static LoggingFacade logger = null;

yeah, sync'd a few minutes ago and was working on changing this.
done.

sankarpn · 2020-06-26T17:16:22Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+  /**
+   * Install Operator.
+   * @param namespaces list of namespaces created by the IntegrationTestWatcher by the
+   *     JUnit engine parameter resolution mechanism


now a simple description is good enough I guess

Suggested change

* JUnit engine parameter resolution mechanism

@param namespaces injected by JUnit

sankarpn · 2020-06-26T17:17:01Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+   */
+  @BeforeAll
+  public static void initAll(@Namespaces(3) List<String> namespaces) {
+    // create standard, reusable retry/backoff policy


Need logger initialized here
logger = getLogger();

sankarpn · 2020-06-26T17:18:06Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+    installIstio();
+
+    // get a new unique opNamespace
+    logger.info("Creating unique namespace for Operator");


Suggested change

logger.info("Creating unique namespace for Operator");

logger.info("Assigning a unique namespace for Operator");

sankarpn · 2020-06-26T17:18:24Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+    assertNotNull(namespaces.get(0), "Namespace list is null");
+    opNamespace = namespaces.get(0);
+
+    logger.info("Creating unique namespace for Domain");


same as above comment

sankarpn · 2020-06-26T17:27:24Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+  @Test
+  @DisplayName("Check cross domain transaction with istio works")
+  @Slow
+  @MustNotRunInParallel


Do we need these 2 tags?

I am going to keep it there for now. There is an issue with the istio service port number which might cause a problem if the istio tests are run in parallel. Will remove it later after that issue is resolved..

@MustNotRunInParallel tag may not help. We need find other solution such as adding host name to the istio service to provide host information in http header.

sankarpn · 2020-06-26T17:35:53Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+      logger.info("\n HTTP response is \n " + result.stdout());
+      logger.info("curl command returned {0}", result.toString());
+      assertTrue(result.stdout().contains("Status=Committed"), "crossDomainTransaction failed");
+    }


Do you want to use java based http client?

String url= String.format("
"http://%s:%s/TxForward/TxForward?urls=t3://%s.%s:7001,t3://%s1.%s:8001,t3://%s1.%s:8001,"
+ "t3://%s2.%s:8001",
K8S_NODEPORT_HOST, istioIngressPort, domain1AdminServerPodName, domain1Namespace,
domain1ManagedServerPrefix, domain1Namespace, domain2ManagedServerPrefix,domain2Namespace,
domain2ManagedServerPrefix,domain2Namespace);

HttpResponse response = assertDoesNotThrow(() -> OracleHttpClient.get(url, true));
assertEquals(200, response.statusCode(), "Status code not equals to 200");
assertTrue(response.body().contains(""Status=Committed"), "crossDomainTransaction failed");

changed to use the http client

sankarpn · 2020-06-26T17:36:54Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+      logger.info("Check for managed server pod {0} existence in namespace {1}",
+          managedServerPrefix + i, domainNamespace);
+      checkPodExists(managedServerPrefix + i, domainUid, domainNamespace);
+    }


we don't need the podExists checks because podReady will do both

It has to be in this order.

admin service check

admin pod ready check

ms service check

ms pod ready check

sankarpn · 2020-06-26T17:37:17Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+      logger.info("Check managed server service {0} is created in namespace {1}",
+          managedServerPrefix + i, domainNamespace);
+      checkServiceExists(managedServerPrefix + i, domainNamespace);
+    }


checkServiceExists should be done before checkPodReady

moved it up.

sankarpn · 2020-06-26T17:37:33Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+    }, "Access to admin server node port failed");
+    assertTrue(loginSuccessful, "Console login validation failed");
+
+     */


remove commented code

sankarpn

Just one more change needed

sankarpn · 2020-06-26T22:36:18Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+      logger.info("Check for managed server pod {0} existence in namespace {1}",
+          managedServerPrefix + i, domainNamespace);
+      checkPodExists(managedServerPrefix + i, domainUid, domainNamespace);
+    }


It has to be in this order.

admin service check

admin pod ready check

ms service check

ms pod ready check

sankarpn

Looks good.

bhavaniravichandran · 2020-06-29T15:38:27Z

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests/1073/

rjeberhard · 2020-06-30T22:38:01Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+//import java.net.http.HttpResponse;


Remove, please.

rjeberhard · 2020-06-30T22:40:37Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+    int istioIngressPort = getIstioHttpIngressPort();
+    logger.info("Istio Ingress Port is {0}", istioIngressPort);
+
+    /*


Please remove any unnecessary code.

rjeberhard · 2020-06-30T22:41:16Z

new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/impl/Domain.java

 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;

+


Please remove extra spaces

I was trying to get the test to pass on Kind cluster and tried to see if retry works. Didn't want to remove the commented code till I found the solution. Finally passed in kind cluster. So, removed all commented code.

rjeberhard

Approving. Before commit, please do remove any commented out imports or code and resolve the conflict.

bhavaniravichandran · 2020-07-01T13:43:47Z

Do not merge yet.

bhavaniravichandran · 2020-07-02T15:11:02Z

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/594/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests/1100/

ok to merge now.

anpanigr · 2020-07-02T16:30:59Z

new-integration-tests/src/test/resources/istio/istio-cdt-http-template-service.yaml

+    istio: ingressgateway
+  servers:
+    - hosts:
+        - '*'


Missing Host information

anpanigr · 2020-07-02T16:32:53Z

new-integration-tests/src/test/resources/istio/istio-cdt-http-template-service.yaml

+    - match:
+        - uri:
+            prefix: /console
+        - uri:


Do you need this uri prefix ? You are not using any REST API to configure domain

you mean the management prefix. I guess not. Will remove it.

anpanigr · 2020-07-02T16:37:23Z

new-integration-tests/src/test/resources/istio/istio-cdt-http-template-service.yaml

+
+    - match:
+        - uri:
+            prefix: /TxForward


This is the only difference between this template and existing istio-http-template.yaml. We can make the application prefix as replaceable and use the same template

I also want to prefix my hostname with the domain name and namespace - not to have conflicts later - if we have 2 domains in the same namespace.

Also, I have to deploy my app to the AS as well.

Keeping it separate for now.

anpanigr · 2020-07-02T16:39:36Z

...ntegration-tests/src/test/java/oracle/weblogic/kubernetes/ItIstioCrossDomainTransaction.java

+  }
+
+  /*
+   * This test verifies cross domain transaction is successful. domain in image using wdt is used


The testname should be modified to testIstioCrossDomainTransaction()
The description does not refers to ISTIO
The description should give more details about the transaction with description of control flow inside the application. This is the only document we refers when the test fails.

For example

Configure two WebLogic Domain(s) with following transnational resources.

Start a 2PC transaction

Enlist a JDBC/JMS Resources from a Server on domain1

Enlist a another transnational resource from domain2

Commit the Transaction

Changed the test name and added more description

anpanigr

LGTM

BHAVANI.RAVICHANDRAN@ORACLE.COM added 4 commits June 24, 2020 22:00

istio cross domain transaction test

18bcd49

fix the image name for jenkins runs

9212825

Fix failure when copying the app out of pod

267fccd

sync with develop

37ac71b

bhavaniravichandran requested review from rjeberhard, anpanigr, ajsomogyi and sankarpn June 26, 2020 15:36

sankarpn suggested changes Jun 26, 2020

View reviewed changes

BHAVANI.RAVICHANDRAN@ORACLE.COM added 2 commits June 26, 2020 17:41

commenting admin console access

7b25b5a

updates after sankar's review comments

21ddae8

sankarpn suggested changes Jun 26, 2020

View reviewed changes

one more change requested by Sankar

e18c998

sankarpn approved these changes Jun 26, 2020

View reviewed changes

BHAVANI.RAVICHANDRAN@ORACLE.COM added 3 commits June 29, 2020 22:00

retry console login due to failure in Kind clsuter

4c09853

add debug

eb916d4

adding username/pwd to curl command

5ff2d0f

rjeberhard reviewed Jun 30, 2020

View reviewed changes

rjeberhard approved these changes Jun 30, 2020

View reviewed changes

removing commented code

76f6a8b

BHAVANI.RAVICHANDRAN@ORACLE.COM added 3 commits July 1, 2020 18:17

revisiting change to run in Kind cluster

198a32d

removing commented code

360b5a8

sync from develop

262ded6

sync develop after Pani's PR merge

a44f07e

anpanigr reviewed Jul 2, 2020

View reviewed changes

update after review comments

02f1f67

anpanigr approved these changes Jul 2, 2020

View reviewed changes

rjeberhard merged commit 291a16c into develop Jul 2, 2020

rjeberhard deleted the istiocdxaction branch January 5, 2021 21:59

	* JUnit engine parameter resolution mechanism
	@param namespaces injected by JUnit

	logger.info("Creating unique namespace for Operator");
	logger.info("Assigning a unique namespace for Operator");

Istiocdxaction #1771

Istiocdxaction #1771

Uh oh!

Conversation

bhavaniravichandran commented Jun 26, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sankarpn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sankarpn left a comment

Choose a reason for hiding this comment

Uh oh!

bhavaniravichandran commented Jun 29, 2020

Uh oh!

rjeberhard Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjeberhard left a comment

Choose a reason for hiding this comment

Uh oh!

bhavaniravichandran commented Jul 1, 2020

rjeberhard Jun 30, 2020 •

edited

Loading

bhavaniravichandran commented Jul 2, 2020 •

edited

Loading

anpanigr Jul 2, 2020 •

edited

Loading

anpanigr Jul 2, 2020 •

edited

Loading