Adding JRF domain into ItJrfDomainInPV #1767
Conversation
| private static final String RCUSYSUSERNAME = "sys"; | ||
| private static final String RCUSYSPASSWORD = "Oradoc_db1"; | ||
| private static final String RCUSCHEMAUSERNAME = "myrcuuser"; | ||
| private static final String RCUSCHEMAPASSWORD = "Oradoc_db1"; | ||
|
|
||
| private static String dbUrl = null; | ||
| private static int dbPort = getNextFreePort(30000, 32767); |
There was a problem hiding this comment.
Do not evaluate and assign this until you are ready to use it.
| @@ -65,38 +110,31 @@ | |||
| * @param namespaces injected by JUnit | |||
| */ | |||
| @BeforeAll | |||
| public static void initAll(@Namespaces(1) List<String> namespaces) { | |||
| public static void initAll(@Namespaces(3) List<String> namespaces) { | |||
There was a problem hiding this comment.
Now you need to initialize the logger in this method and remove the implements LoggedTest.
See #1765
There was a problem hiding this comment.
Yeah, when I merged to the latest develop branch I can see the conflicts.
| for (int i = 1; i <= replicaCount; i++) { | ||
| logger.info("Checking managed server service {0} is created in namespace {1}", | ||
| managedServerPodNamePrefix + i, jrfDomainNamespace); | ||
| checkServiceExists(managedServerPodNamePrefix + i, jrfDomainNamespace); |
There was a problem hiding this comment.
Move the checkServiceExists before checkPodReady for both admin and managed server pods.
There are instances where when service creation fails, the pods never become ready and the error log messages will be misleading
| * @param password passowrd in the secret | ||
| */ | ||
| public static void createRcuSecretWithUsernamePassword(String secretName, String namespace, | ||
| String username, String password, String sysUsername, String sysPassword) { |
There was a problem hiding this comment.
missing params sysUsername and sysPassword in javadoc
| * @param domainUid domain UID | ||
| * @param className name of the class to call this method | ||
| */ | ||
| public static void createPV(String pvName, String domainUid, String className) { |
There was a problem hiding this comment.
You need to get logger in each method it looks like.
LoggingFacade logger = getLogger();
| * @param namespace name of the namespace in which to create the persistent volume claim | ||
| */ | ||
| public static void createPVC(String pvName, String pvcName, String domainUid, String namespace) { | ||
| logger.info("creating persistent volume claim for pvName {0}, pvcName {1}, " |
There was a problem hiding this comment.
create logger, same applies for methods you are adding.
This PR is to 1) add JRF domain on PV into test class ItJrfDomainInPV and verify the servers startup and services are created; 2) fix intermittent DB pod creation failure on the remote cluster
Jenkins cluster test result:
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests-1/43/testReport/
Kind cluster test result:
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/506/testReport/oracle.weblogic.kubernetes/