Additional rcudb validation #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshum2479
requested review from
robertpatrick,
ddsharpe,
rakillen and
CarolynRountree
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -272,6 +272,11 @@ def __run_rcu(self): | |||
| rcu_sys_pass = rcu_db_info.get_preferred_sys_pass() | |||
| rcu_schema_pass = rcu_db_info.get_preferred_schema_pass() | |||
|
|
|||
| databaseType = rcu_db_info.get_database_type() | |||
| if databaseType is not None and databaseType not in ['SSL', 'ATP', 'ORACLE']: | |||
There was a problem hiding this comment.
Please make this list a constant in case we ever need to use it elsewhere and/or change the items in the list.
| self.__set_connection_property(location, DRIVER_PARAMS_NET_FAN_ENABLED, 'false') | ||
| self.__set_connection_property_info(location, DRIVER_PARAMS_TRUSTSTOREPWD_PROPERTY, truststore_pwd, | ||
| properties_set, encrypted=True) | ||
| self.__set_connection_property_info(location, DRIVER_PARAMS_NET_SSL_VERSION, '1.2', properties_set) |
There was a problem hiding this comment.
Maybe the SSL version value should be a constant since presumably, it may change in the future?
robertpatrick
approved these changes
Feb 17, 2023
rakillen
approved these changes
Feb 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
CarolynRountree
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more validations to RCUDbinfo:
(1) databaseType must be ATP, SSL or ORACLE
(2) check for file existence for data source params property that reference file: keystore, truststore
(3) log RCU data source driver param setting to assist diagnostics