various atp and ssl JRF database refactoring #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshum2479
requested review from
robertpatrick,
ddsharpe,
rakillen and
CarolynRountree
oracle-contributor-agreement
bot
added
the
OCA Verified
ddsharpe
approved these changes
Jan 26, 2023
|
|
||
| runner.atpDB = true; // "ATP".equals(databaseType); // or scan if there are any 'ssl' in properties ? | ||
| runner.atpSSlArgs = sslArgs.toString(); | ||
| runner.sSlArgs = sslArgs.toString(); |
There was a problem hiding this comment.
runner.sslArgs is a more appropriate name
|
|
||
| runner.sslDB = true; | ||
| runner.atpSSlArgs = sslArgs.toString(); | ||
| runner.sSlArgs = sslArgs.toString(); |
| @@ -377,11 +350,11 @@ private String[] getCommandLineArgs(String operationSwitch) { | |||
| arguments.add(SERVER_DN_SWITCH); | |||
| arguments.add("CN=ignored"); | |||
| arguments.add(SSLARGS); | |||
| arguments.add(atpSSlArgs); | |||
| arguments.add(sSlArgs); | |||
|
|
||
| if not ssl_conn_properties.has_key(DRIVER_PARAMS_NET_FAN_ENABLED): | ||
| ssl_conn_properties[DRIVER_PARAMS_NET_FAN_ENABLED] = 'false' | ||
| ssl_conn_properties[DRIVER_PARAMS_NET_SSL_VERSION] = '1.2' |
There was a problem hiding this comment.
why don't we set this only if it is not set, like you are doing for the previous property?
There was a problem hiding this comment.
Actually, the fan enabled should always be false, plus these properties must be that value for it to work properly. There is a comment in the code, not sure why it didn't show up in PR.
# hard coding for now, may need to expose it if ATP access changed later
| if not ssl_conn_properties.has_key(DRIVER_PARAMS_NET_FAN_ENABLED): | ||
| ssl_conn_properties[DRIVER_PARAMS_NET_FAN_ENABLED] = 'false' | ||
| ssl_conn_properties[DRIVER_PARAMS_NET_SSL_VERSION] = '1.2' | ||
| ssl_conn_properties[DRIVER_PARAMS_NET_SERVER_DN_MATCH_PROPERTY] = 'false' |
There was a problem hiding this comment.
same comment about only setting if not already specified.
rakillen
approved these changes
Jan 26, 2023
|
Kudos, SonarCloud Quality Gate passed! |
robertpatrick
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes -run_rcu against SSL database and various refactoring of both ATP and SSL JRF database domain creation.