Support remote app deploy #1355
Conversation
jshum2479
requested review from
rosemarymarano,
robertpatrick,
rakillen and
CarolynRountree
oracle-contributor-agreement
bot
added
the
OCA Verified
| self.__logger.throwing(class_name=self.__class_name, method_name=_method_name, error=pwe) | ||
| raise pwe | ||
| return name | ||
| self.__logger.exiting(class_name=self.__class_name, method_name=_method_name) |
There was a problem hiding this comment.
Should this logging call be before the return?
|
Please double check your copyrights. core/src/main/python/wlsdeploy/tool/deploy/applications_deployer.py needs to be updated to 2023, not sure about others |
There was a problem hiding this comment.
Please remove WDT 3.0 doc changes from the PR and put into the branch for PR #1340
| * @return true if the path should not be used for remote update | ||
| * @throws IllegalArgumentException if the path is null or empty | ||
| */ | ||
| public boolean isRemoteUpdateDomainForbiddenPath(String path) throws IllegalArgumentException { |
There was a problem hiding this comment.
I'm not sure that this is the best place for this logic. In my opinion, the archive file shouldn't know anything about remote mode. Can't we put this into archive_helper.py?
| CommandLineArgUtil.MODEL_FILE_SWITCH | ||
| ] | ||
|
|
||
| __optional_arguments = [ | ||
| # Used by shell script to locate WLST | ||
| CommandLineArgUtil.DOMAIN_HOME_SWITCH, |
There was a problem hiding this comment.
Is there ever a case where the model for a remote deploy operation might have a domain home token? If so, what happens if the user did not provide the domain home path on the remote machine?
| @@ -44,12 +46,12 @@ | |||
|
|
|||
| __required_arguments = [ | |||
| CommandLineArgUtil.ORACLE_HOME_SWITCH, | |||
| CommandLineArgUtil.DOMAIN_HOME_SWITCH, | |||
There was a problem hiding this comment.
Same questions as for Deploy. For discoverDomain -remote, we still require the user to provide -domain_home to support tokenization. I would think we might need this for at least updateDomain -remote if not all remote operations.
| @@ -71,7 +71,7 @@ if "%SHOW_USAGE%" == "false" ( | |||
| ECHO. | |||
| ECHO Usage: %SCRIPT_NAME% [-help] [-use_encryption] | |||
| ECHO [-oracle_home ^<oracle_home^>] | |||
| ECHO -domain_home ^<domain_home^> | |||
| ECHO [-domain_home ^<domain_home^>] | |||
There was a problem hiding this comment.
Make this consistent if you change based on comments above
| @@ -32,7 +32,7 @@ usage() { | |||
| echo "" | |||
| echo "Usage: $1 [-help] [-use_encryption]" | |||
| echo " [-oracle_home <oracle_home>]" | |||
| echo " -domain_home <domain_home>" | |||
| echo " [-domain_home <domain_home>]" | |||
There was a problem hiding this comment.
Make consistent if we change based on comments above
|
Kudos, SonarCloud Quality Gate passed! |
This PR adds support for remote updating a domain and deploying applications. I also refactored some of the sonar complexities warnings in application_deployer.