Skip to content

Various RCU related update #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Sep 16, 2022
Merged

Various RCU related update #1193

merged 33 commits into from
Sep 16, 2022

Conversation

jshum2479
Copy link
Member

This PR ccovers

  • Remove he use of getDatabaseDefaults when creating JRF domain
  • Deprecate the user of several atp.* and ssl.* fields in RCUDbInfo
  • Added documentation how to support multi data source, AGL in sparse model
  • Refactoring

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Aug 31, 2022
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When singing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

Copy link
Member

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits

@@ -1,10 +1,31 @@
### Specifying RCU connection information in the model

During creating or updating a domain, there is new section `RCUDbInfo` in the model, under the `domainInfo` section, for specifying RCU database connection information without using the command-line arguments `-rcu_db` and `-rcu_prefix`. Use this to support a database where the connection string is more complex and requires extra options.
When creating a JRF domain, you can provide all the RCU connection information in a section `RCUDbInfo` under the `domainInfo` section in the model.
It provides you with more flexibility over the basic command line arguments of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command line -> command-line

| opss-audit-DBDS | jdbc/AuditAppendDataSource | prefix_IAU_APPEND | admin server and cluster |
| mds-owsm | jdbc/mds/owsm | prefix_MDS | admin server and cluster |

By default, the JRF domain template data source only has the default information such as URL and schema with the default prefix `DEV`. During domain creation,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only has -> has only

By default, the JRF domain template data source only has the default information such as URL and schema with the default prefix `DEV`. During domain creation,
WDT will use the information you provided in the command line or in the `RCUDbinfo` section to override the default values from the template so that it can connect to the database you specified.

For some advanced use case, such as using Oracle Active Grid Link data source or Multi data sources, you can provide a sparse model of the above data sources in a separate model file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

advanced use case -> advanced use cases
using Oracle -> using an Oracle
Active Grid Link -> Active GridLink data source
Multi data sources -> Multi Data Sources
of the above data sources -> of the data sources

WDT will use the information you provided in the command line or in the `RCUDbinfo` section to override the default values from the template so that it can connect to the database you specified.

For some advanced use case, such as using Oracle Active Grid Link data source or Multi data sources, you can provide a sparse model of the above data sources in a separate model file
during domain creation. See [Advance use cases](#advanced-jrf-database-use-cases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period at the end of the sentence.


### Access a database using a wallet

When accessing a database using a wallet, you need to obtain the wallet from your DBA and information about the database:
When accessing a database such as ATP or SSL using a wallet, you need to obtain the wallet from your DBA and information about the database:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

database such as ATP or SSL -> database, such as ATP or SSL, (two commas needed)

#### Multi Data Sources

If your database does not support high availability natively such as RAC or AGL, then WebLogic provides a Multi Data Source option, which basically the main data source is a logical data source that
contains multiple physical data sources. In order to create a spare model, you can for each data source
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can for each data source -> for each data source, you can:

contains multiple physical data sources. In order to create a spare model, you can for each data source

1. Update the templated data source `URL`, `EncryptedPassword`, and 'user' property value. In the `URL` part, you can specify one of the accessible physical database URL.
2. Duplicate each datasource two times
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period at the end of the sentence


1. Update the templated data source `URL`, `EncryptedPassword`, and 'user' property value. In the `URL` part, you can specify one of the accessible physical database URL.
2. Duplicate each datasource two times
3. Change the duplicated data source name, `JNDIName` by appending `-1`, `-2` etc. The `-1`, `-2` data sources are the physical data source, you will need to update their `URL` too.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc -> , and such.
data source, you will -> data sources; (semi-colon) you will

2. Duplicate each datasource two times
3. Change the duplicated data source name, `JNDIName` by appending `-1`, `-2` etc. The `-1`, `-2` data sources are the physical data source, you will need to update their `URL` too.

For example (note: details replaced by `....` for easier reading),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading), -> reading): (colon)

....
```

You can run WDT tool `modelHelp.sh -oracle_home <oracle home> resources:/JDBCSystemResource/JdbcResource/JDBCDataSourceParams` for the complete list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-write: For the complete list of fields, run the WDT command, modelHelp.sh -oracle_home <oracle home> resources:/JDBCSystemResource/JdbcResource/JDBCOracleParmas.

Copy link
Member

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor fixes otherwise ok.

For the complete list of fields, run the WDT command,

```shell
modelHelp.sh -oracle_home <oracle home> resources:/JDBCSystemResource/JdbcResource/JDBCOracleParams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preceded commands with a dollar sign ($)
$ modelHelp.sh

For the complete list of fields, run the WDT command,

```shell
modelHelp.sh -oracle_home <oracle home> resources:/JDBCSystemResource/JdbcResource/JDBCOracleParams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ modelHelp.sh

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@robertpatrick robertpatrick merged commit 324753e into main Sep 16, 2022
@robertpatrick robertpatrick deleted the wdt-636-mds branch September 16, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants