WDT-659 cleanup CLAException for compare_model.py #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakillen
reviewed
Jul 20, 2022
| @@ -254,20 +260,11 @@ def main(): | |||
|
|
|||
| for f in [model1, model2]: | |||
| if not os.path.exists(f): | |||
| raise CLAException("Model %s does not exists" % f) | |||
| raise CLAException(2, 'WLSDPLY-85717', [f]) | |||
There was a problem hiding this comment.
Can this use ExitCode.ERROR ? (recently merged to main).
3 places in this file.
ddsharpe
reviewed
Jul 20, 2022
| or FileUtils.isJsonFile(model1_file) and FileUtils.isJsonFile(model2_file)): | ||
| ext = os.path.splitext(model1)[1] | ||
| raise CLAException("Model %s is not a %s file " % (model2, ext)) | ||
| raise CLAException(2, 'WLSDPLY-85718', [f]) |
There was a problem hiding this comment.
Shouldn't these literal 2's use the static ExitCode.ERROR
There was a problem hiding this comment.
I didn't know there is such a thing, CLAException constructor hard coded as 2.
ddsharpe
reviewed
Jul 21, 2022
| @@ -232,6 +232,12 @@ def debug(format_string, *arguments): | |||
| else: | |||
| _logger.finest(format_string, arguments) | |||
|
|
|||
| def _checkModelExtension(file): | |||
There was a problem hiding this comment.
python function names should be Snake case, not camel case.
ddsharpe
approved these changes
Jul 21, 2022
rakillen
approved these changes
Jul 21, 2022
|
Kudos, SonarCloud Quality Gate passed! |
CarolynRountree
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanup CLAExceptions and exit code logic