Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a commented-out option to allow a private network for PL/SQL debu… #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CBatemanOracle
Copy link
Member

…gging.

…gging.

Signed-off-by: Cameron Bateman <cameron.bateman@oracle.com>
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 23, 2023
@PaulNeumann
Copy link
Contributor

I like this idea, but I have a couple of comments.

  • If this is implemented, I think it should be done for all of the single instance database projects, not just 19.3.0.
  • I think it should be configured using environment variables (and, optionally, the vagrant-env plugin), to be consistent with the other configurable parameters, and to make it unnecessary to modify the Vagrantfile.
  • I don't think the 192.168 address range will work for the libvirt provider.
  • I think the README.md file should be updated to include this enhancement.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants