[GR-18163] Do not consider deprecated functions as errors for core C extensions and prefer OpenSSL 3.0, then OpenSSL 3.x, then OpenSSL 1.1 #3759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Should help when 1.1 is removed like in actions/runner-images#10817 * 1.1 is EOL (cherry picked from commit 9ddc5e8)
* This was problematic for extconf.rb checks as they would think such deprecated functions do not exist. Notably it caused the openssl extconf.rb for openssl 3.4.0 to think there is no TS_VERIFY_CTS_set_certs() and then openssl_missing.h would redefine it, causing a compilation error. * CRuby does not set -Werror for core C extensions, maybe we should not either. OTOH it is useful to notice new warnings in core C extensions, even more with mx hiding the output by default now. * Note that changing $warnflags or $defs only affects the Makefile, but not the have_func() checks. * Fixes #3724
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer OpenSSL 3.0, then OpenSSL 3.x, then OpenSSL 1.1
(cherry picked from commit 9ddc5e8)
Do not consider deprecated functions as errors for core C extensions
Notably it caused the openssl extconf.rb for openssl 3.4.0 to think there is no
TS_VERIFY_CTS_set_certs() and then openssl_missing.h would redefine it, causing a compilation error.
OTOH it is useful to notice new warnings in core C extensions, even more with mx hiding the output by default now.