Skip to content

Improve specification and compatibility of implementation of Signal.trap #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2021
Merged

Improve specification and compatibility of implementation of Signal.trap #2287

merged 1 commit into from
Mar 8, 2021

Conversation

chrisseaton
Copy link
Collaborator

No description provided.

@chrisseaton chrisseaton requested a review from eregon March 8, 2021 01:06
@chrisseaton chrisseaton added compatibility shopify Pull requests from Shopify labels Mar 8, 2021
eregon
eregon reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great in general, but I'd like to keep trap specs in spec/ruby/core/signal/trap_spec.rb (see comment)

eregon
eregon reviewed Mar 8, 2021
View reviewed changes
eregon
eregon reviewed Mar 8, 2021
View reviewed changes
@chrisseaton
Copy link
Collaborator Author

Read for review again.

@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Mar 8, 2021
@eregon eregon self-assigned this Mar 8, 2021
graalvmbot pushed a commit that referenced this pull request Mar 8, 2021
@eregon
[GR-19220] Improve Signal.trap specs and implementation (#2287)
c6bdf79 
PullRequest: truffleruby/2481
@graalvmbot graalvmbot merged commit 95b5c8e into oracle:master Mar 8, 2021
@chrisseaton chrisseaton deleted the signals branch March 9, 2021 00:47
@eregon
Copy link
Member

eregon commented Mar 10, 2021

I think this PR kind of broke Ctrl+C (it raises a different exception):

ruby -e sleep
^C<internal:core> core/main.rb:76:in `block (2 levels) in <top (required)>': wrong number of arguments (given 1, expected 0) (ArgumentError)
	from -e:1:in `sleep'
	from -e:1:in `<main>'

@chrisseaton chrisseaton mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees

@eregon eregon

Labels
compatibility in-ci The PR is being tested in CI. Do not push new commits. oca-signed shopify Pull requests from Shopify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisseaton @eregon @graalvmbot