Skip to content

Implement String#undump #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

Implement String#undump #2131

merged 1 commit into from
Oct 30, 2020

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Oct 25, 2020

Implements the previously unimplemented String#undump method.
The implementation is adapted from JRuby's.

@chrisseaton
Copy link
Collaborator

Thanks for this - normally I'd say to try to write this in Ruby.... but this kind of tight loop we can copy and paste from JRuby is fine.

eregon
eregon reviewed Oct 26, 2020
View reviewed changes
@kustosz kustosz requested a review from eregon October 27, 2020 10:31
eregon
eregon reviewed Oct 27, 2020
View reviewed changes
@eregon eregon self-assigned this Oct 27, 2020
@eregon eregon added this to the 21.0.0 milestone Oct 27, 2020
@kustosz kustosz requested a review from eregon October 29, 2020 20:03
@kustosz
Copy link
Contributor Author

kustosz commented Oct 29, 2020

Just pushed fixes for your latest batch of comments :)

eregon
eregon approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the PR!

Would you mind squashing the commits?
(I could squash myself but then the PR won't be marked as merged on GitHub, since we don't merge on GitHub directly but the internal CI does)

@kustosz
Copy link
Contributor Author

kustosz commented Oct 30, 2020

Squashed :)

@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Oct 30, 2020
@graalvmbot
Copy link
Collaborator

Hello Marcin Kostrzewa, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address marckostrzewa -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@eregon
Copy link
Member

eregon commented Oct 30, 2020

(The OCA check is fine, I just added you to the check list as you already signed it)

@graalvmbot
Copy link
Collaborator

Marcin Kostrzewa has signed the Oracle Contributor Agreement (based on email address marckostrzewa -(at)- gmail -(dot)- com) so can contribute to this repository.

graalvmbot pushed a commit that referenced this pull request Oct 30, 2020
@eregon
[GR-18163] Implement String#undump (#2131)
74ef80f 
PullRequest: truffleruby/2114
@graalvmbot graalvmbot merged commit 3373bf9 into oracle:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees

@eregon eregon

Labels
compatibility in-ci The PR is being tested in CI. Do not push new commits. oca-signed
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kustosz @chrisseaton @graalvmbot @eregon