Skip to content

Handle foreign null object as falsy value #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2020
Merged

Handle foreign null object as falsy value #2055

merged 2 commits into from
Jul 29, 2020

Conversation

ssnickolay
Copy link
Collaborator

Closes #1902

@ssnickolay ssnickolay force-pushed the fix/foreign-object-to-boolean branch from 1969e8d to 3681c6b Compare July 27, 2020 18:20
ssnickolay
ssnickolay commented Jul 27, 2020
View reviewed changes
@ssnickolay ssnickolay force-pushed the fix/foreign-object-to-boolean branch from 3681c6b to 900fd3b Compare July 28, 2020 12:19
ssnickolay
ssnickolay commented Jul 28, 2020
View reviewed changes
eregon
eregon reviewed Jul 28, 2020
View reviewed changes
@ssnickolay ssnickolay force-pushed the fix/foreign-object-to-boolean branch from 900fd3b to ea2e51e Compare July 28, 2020 14:35
@ssnickolay ssnickolay force-pushed the fix/foreign-object-to-boolean branch from ea2e51e to f5009e3 Compare July 29, 2020 08:19
eregon
eregon reviewed Jul 29, 2020
View reviewed changes
@ssnickolay ssnickolay force-pushed the fix/foreign-object-to-boolean branch 2 times, most recently from 9f31aad to 14598f5 Compare July 29, 2020 12:52
@ssnickolay ssnickolay force-pushed the fix/foreign-object-to-boolean branch from 14598f5 to 5c4c9ba Compare July 29, 2020 12:53
@ssnickolay ssnickolay requested a review from eregon July 29, 2020 12:53
eregon
eregon approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the quick turnarounds!

@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Jul 29, 2020
@eregon eregon self-assigned this Jul 29, 2020
@eregon eregon added this to the 20.3.0 milestone Jul 29, 2020
graalvmbot pushed a commit that referenced this pull request Jul 29, 2020
@eregon
[GR-18163] Handle foreign null object as falsy value (#2055).
ad9bbf2 
PullRequest: truffleruby/1814
@graalvmbot graalvmbot merged commit 5c4c9ba into oracle:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees

@eregon eregon

Labels
in-ci The PR is being tested in CI. Do not push new commits. oca-signed
Projects
None yet
Milestone
20.3.0
Development

Successfully merging this pull request may close these issues.

[interop] foreign null objects not handled correctly as falsy values
3 participants
@ssnickolay @eregon @graalvmbot