Skip to content

Conversation

kipply
Copy link
Contributor

@kipply kipply commented Feb 14, 2020

Cuts another method off of the unimplemented list!

Shopify#1

Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
@kipply kipply force-pushed the proc-to-obj-implmentation branch from b3b16fc to f40ae0c Compare February 14, 2020 19:25
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@eregon eregon self-assigned this Feb 19, 2020
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Feb 19, 2020
@eregon eregon added this to the 20.1.0 milestone Feb 19, 2020
graalvmbot pushed a commit that referenced this pull request Feb 19, 2020
PullRequest: truffleruby/1381
@eregon
Copy link
Member

eregon commented Feb 19, 2020

Merged in 61d5975.
(Unfortunately GitHub doesn't detect the merge due to the extra merge commit here)

@eregon eregon closed this Feb 19, 2020
@chrisseaton chrisseaton deleted the proc-to-obj-implmentation branch March 14, 2020 22:00
@chrisseaton chrisseaton added the shopify Pull requests from Shopify label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-ci The PR is being tested in CI. Do not push new commits. oca-signed shopify Pull requests from Shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants