Implement rb_define_class_id, rb_module_new and rb_define_module_id #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No specs cause these are fairly trivial.
aardvark179
approved these changes
Jan 3, 2020
aardvark179
added
the
in-ci
eregon
approved these changes
Jan 3, 2020
eregon
reviewed
Jan 3, 2020
| @@ -75,6 +75,7 @@ Compatibility: | |||
| * Include the major kernel version in `RUBY_PLATFORM` on macOS like MRI (#1860, @eightbitraptor). | |||
| * Implemented `Enumerator::Chain`, `Enumerator#+`, and `Enumerable#chain` (#1859, #1858). | |||
| * Implemented `Thread#backtrace_locations` and `Exception#backtrace_locations` (#1556). | |||
| * Implemented `rb_module_new`, `rb_define_class_id`, `rb_define_module_id`, (#1876, @chrisseaton). | |||
There was a problem hiding this comment.
Should we mention @XrXr too here since he did the first commit?
graalvmbot
pushed a commit
that referenced
this pull request
Jan 3, 2020
…module_id (#1876). PullRequest: truffleruby/1235
Sorry yes please can you make that correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify#1