Implement rb_respond_to in Ruby to cover primitive cases #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
approved these changes
Dec 31, 2019
|
This should have a spec to make sure we don't regress, I'll add one. |
|
There is a spec in https://github.com/oracle/truffleruby/pull/1870/files, I'll cherry-pick it in this PR. |
bjfish
reviewed
Jan 3, 2020
| @@ -947,6 +947,10 @@ def rb_funcall_with_block(recv, meth, args, block) | |||
| recv.public_send(meth, *args, &block) | |||
| end | |||
|
|
|||
| def rb_respond_to(object, name) | |||
| object.respond_to?(name) | |||
There was a problem hiding this comment.
I think this is out of scope for this PR but I thought I'd mention that rb_respond_to may have slightly different behavior:
https://github.com/ruby/ruby/blob/650c45dcd70e791747c4b9084c100cb895e718cb/vm_method.c#L2036-L2050
than obj_respond_to:
https://github.com/ruby/ruby/blob/650c45dcd70e791747c4b9084c100cb895e718cb/vm_method.c#L2074
graalvmbot
pushed a commit
that referenced
this pull request
Jan 3, 2020
PullRequest: truffleruby/1230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify#1