Process::Status#to_i: return raw waitpid(2) status #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardvark179
approved these changes
Nov 6, 2019
eregon
reviewed
Nov 6, 2019
| @@ -729,19 +731,20 @@ class Status | |||
| attr_reader :termsig | |||
| attr_reader :stopsig | |||
|
|
|||
| def initialize(pid=nil, status=nil, termsig=nil, stopsig=nil) | |||
| def initialize(pid=nil, status=nil, termsig=nil, stopsig=nil, raw_status=nil) | |||
| @pid = pid | |||
| @status = status | |||
There was a problem hiding this comment.
I think we should rename this to @exitstatus to avoid confusion and mirror the C macro names.
aardvark179
reviewed
Nov 6, 2019
|
I run all the test in my machine and saw no failures with my last commit. |
eregon
reviewed
Nov 7, 2019
| end | ||
|
|
||
| def coredump? | ||
| false | ||
| end | ||
|
|
||
| def exited? | ||
| @status != nil | ||
| @raw_status != nil |
There was a problem hiding this comment.
Thanks. We will need test coverage on those as well.
There was a problem hiding this comment.
Good point, actually there are already specs but one of the exited? specs was tagged. That one fails with @raw_status.
@raw_status seems to work in success? but I think it's just luck of the native encoding for exited.
There was a problem hiding this comment.
Together with #1790 we pass all Process::Status specs.
| @@ -779,14 +782,14 @@ def stopped? | |||
|
|
|||
| def success? | |||
| if exited? | |||
| @status == 0 | |||
| @raw_status == 0 | |||
graalvmbot
pushed a commit
that referenced
this pull request
Nov 8, 2019
PullRequest: truffleruby/1121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify#1