Match out of range ArgumentError message with MRI #1774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 28, 2019
rafaelfranca
force-pushed
the
rm-fix-out-of-range-error
branch
from
b07ff12 to
96b24bc
Compare
|
Added the CHANGELOG entry |
eregon
approved these changes
Oct 29, 2019
|
@rafaelfranca Could you rebase this PR on top of current master (which has the CHANGELOG fixes)? |
rafaelfranca
force-pushed
the
rm-fix-out-of-range-error
branch
from
96b24bc to
f38d3ca
Compare
|
Done |
rafaelfranca
force-pushed
the
rm-fix-out-of-range-error
branch
from
f38d3ca to
176d2c3
Compare
graalvmbot
pushed a commit
that referenced
this pull request
Oct 30, 2019
PullRequest: truffleruby/1094
|
Merged, thanks. |
|
Yeah.... I found that too but chose to not spec it since our behavior would be different. The reason for that behavior is that MRI uses 4 bits to store the value for month. If the value is inside the 0-15 range it can be stored in the struct and later checked against the range of valid months. If the value is outside that range it will raise an error earlier. |
|
Interesting, thanks for the explanation and links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Support is asserting on this message, so I thought we could get it to match.
Shopify#1