Skip to content

Fix Tempfile#size and #length when the IO is not flushed #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix Tempfile#size and #length when the IO is not flushed #1765

wants to merge 2 commits into from

Conversation

rafaelfranca
Copy link
Contributor

@rafaelfranca rafaelfranca commented Oct 11, 2019 •
edited
Loading

On MRI, File#size implementation relies on the fact that it calls rb_io_flush_raw and that function flush the IO before calculating the size.

Now we are doing the same to follow the same behavior of MRI.

This bug was found while trying to get the rack test suite passing with TruffleRuby.

Shopify#1

@graalvmbot
Copy link
Collaborator

Hello Rafael Mendonça França, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address rafael -(dot)- franca -(at)- shopify -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@rafaelfranca
Copy link
Contributor Author

I have signed the OCA.

@eregon
Copy link
Member

eregon commented Oct 11, 2019

@rafaelfranca Thank you for the PR!

When did you submit the OCA?
It can take a little while to process, I don't see it on https://www.oracle.com/technetwork/community/oca-486395.html yet.

@rafaelfranca
Copy link
Contributor Author

@rafaelfranca Thank you for the PR!

Expect more coming. We have a few in our fork.

When did you submit the OCA?

I sent it a couple of hours ago. I was not expecting it to be fast, just replied to the bot that asked me to comment when if I already signed it.

@graalvmbot
Copy link
Collaborator

Rafael Mendonça França has signed the Oracle Contributor Agreement (based on email address rafael -(dot)- franca -(at)- shopify -(dot)- com) so can contribute to this repository.

eregon
eregon approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@eregon eregon self-assigned this Oct 26, 2019
@eregon eregon added this to the 20.0.0 milestone Oct 26, 2019
@rafaelfranca
Fix Tempfile#size and #length when the IO is not flushed
1047899 
On MRI, File#size implementation relies on the fact that it calls
rb_io_flush_raw and that function flush the IO before calculating the
size.

Now we are doing the same to follow the same behavior of MRI.
@rafaelfranca
Add CHANGELOG entry
0c97ace
@rafaelfranca
Copy link
Contributor Author

Added CHANGELOG entry

graalvmbot pushed a commit that referenced this pull request Oct 28, 2019
@eregon
[GR-19188] Fix Tempfile#size and #length when the IO is not flushed (#…
68dcd88 
…1765).

PullRequest: truffleruby/1084
@eregon
Copy link
Member

eregon commented Oct 28, 2019 •
edited
Loading

Merged in 68dcd88 (with the PR number reference in the merge message).
I am sorry it doesn't match the latest commit on this PR, the reason is I added the changelog entry internally before you pushed it.

@eregon eregon closed this Oct 28, 2019
@chrisseaton chrisseaton added the shopify Pull requests from Shopify label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees

@eregon eregon

Labels
oca-signed shopify Pull requests from Shopify
Projects
None yet
Milestone
20.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rafaelfranca @graalvmbot @eregon @chrisseaton