Socket#setsockopt broken with nil or false value.

[ioquatix]

If optval is false, it would fail to match correctly. Proposed fix:

  def setsockopt(level_or_option, optname = nil, optval = nil)
    if level_or_option and optname

[ioquatix]

I worked around this issue by ensuring I only call this function with optval = 1.

[ioquatix]

The Ruby documentation specifically allows true/false just FYI.

[ioquatix]

@eregon has this been fixed yet?

[eregon]

I'm not sure, I'll take a look.

[eregon]

We already have a failing spec for this, great:
BasicSocket#setsockopt sets the socket option Socket::SO_OOBINLINE

truffleruby/spec/ruby/library/socket/basicsocket/setsockopt_spec.rb

Line 56 in 5defdc8

@sock.setsockopt(Socket::SOL_SOCKET, Socket::SO_OOBINLINE, false).should == 0

[eregon]

@ioquatix I fixed this in 2465104, thanks for the bug report!