LocalDateTime Conversion for TIMESTAMP WITH LOCAL TIME ZONE #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
All tests in this branch are successful with r2dbc client in France and db in the US. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4
The 21.1 Oracle JDBC Driver implements TIMESTAMP WITH LOCAL TIME ZONE to LocalDateTime conversion by returning a date time value in the database time zone. The correct behavior is to return the value in the time zone of the JVM. This branch works around that defect by having Oracle JDBC convert to a java.sql.Timestamp, and then converting from Timestamp to LocalDateTime at the R2DBC layer. Oracle JDBC's conversion to Timestamp is correct; It will adjust the database timezone value to the JVM timezone.