19 descriptor sample #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +115,7 @@ public static void main(String[] args) throws URISyntaxException { | |||
| .option(ConnectionFactoryOptions.DRIVER, "oracle") | |||
| .option(ConnectionFactoryOptions.HOST, HOST) | |||
| .option(ConnectionFactoryOptions.PORT, PORT) | |||
| .option(ConnectionFactoryOptions.DATABASE, DatabaseConfig.SERVICE_NAME) | |||
There was a problem hiding this comment.
Just curious why only the service name comes from DatabaseConfig? Why not host, port, etc?
There was a problem hiding this comment.
Ah, the worst enemy of code reviewers strikes again: There are static imports for HOST, PORT, but not for SERVICE_NAME. I corrected this in the next commit, now SERVICE_NAME is a static import as well.
Douglas-Surber
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a new code sample that uses a TNS descriptor to connect Oracle R2DBC to a database.
This branch also add a common DatabaseConfig class that all sample code can share. There was a mistake in the example config.properties that is also fixed: A service name is specified as the value of "SERVICE_NAME", not as the value of "DATABASE".