Skip to content

refactor writeXref() timeout code to XrefWork #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vladak merged 2 commits into from
May 2, 2023
Merged

refactor writeXref() timeout code to XrefWork #4332

vladak merged 2 commits into from
May 2, 2023

Conversation

@vladak
Copy link
Member

@vladak vladak commented May 2, 2023 •
edited
Loading

After adding writeXref() timeout to XMLAnalyzer in #4328, IDEA detected code duplication of the CompletableFuture code block there and in PlainAnalyzer. This change moves that block to XrefWork and also uses it in more analyzer classes, providing better indexer robustness.

The IOException raised by writeXref() is now wrapped inside ExecutionException.

@vladak vladak added the indexer label May 2, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 2, 2023
@vladak vladak changed the title refactor writeXref() code to XrefWork refactor writeXref() timeout code to XrefWork May 2, 2023
@vladak vladak merged commit bfc6067 into oracle:master May 2, 2023
@vladak vladak deleted the xref_work_refactor branch May 2, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

indexer OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vladak